netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Jarosch <thomas.jarosch@intra2net.com>
To: netfilter-devel@vger.kernel.org
Cc: Tim Gardner <timg@tpi.com>
Subject: Re: [PATCH] xt_recent: Fix false hit_count match
Date: Fri, 19 Mar 2010 16:04:45 +0100	[thread overview]
Message-ID: <201003191604.45719.thomas.jarosch@intra2net.com> (raw)
In-Reply-To: <4B83DF52.5000806@trash.net>

On Tuesday, 23. February 2010 14:59:46 Patrick McHardy wrote:
> Tim Gardner wrote:
> >>From 146111514a8c126268e848e45b7dd967329b072f Mon Sep 17 00:00:00 2001
> >>
> > From: Tim Gardner <tim.gardner@canonical.com>
> > Date: Thu, 18 Feb 2010 20:33:00 -0700
> > Subject: [PATCH] xt_recent: Fix false match.
> > 
> > A rule with a zero hit_count will always match.
> 
> Also applied, thanks Tim.

I just updated from kernel 2.6.32.9 to kernel 2.6.32.10 which contains
the xt_recent "zero hit_count will always match" fix.

After that xt_recent stopped working for this scenario:

iptables -A INPUT -m recent --rcheck --rdest --name INET_IP -j LOG
echo "+1.2.3.4" >/proc/net/xt_recent/INET_IP

The ip address 1.2.3.4 represents the current ip of my dial up connection.

If I change "--rcheck" to "--update", it works again.
Reverting the patch fixes the issue.

Maybe this is related to the xt_recent
proc interface creating the entry
(with a zero hit count)?

Cheers,
Thomas

  reply	other threads:[~2010-03-19 15:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-19 17:49 [PATCH] xt_recent: Fix false hit_count match Tim Gardner
2010-02-23 13:59 ` Patrick McHardy
2010-03-19 15:04   ` Thomas Jarosch [this message]
2010-03-19 15:41     ` Patrick McHardy
2010-03-19 16:14       ` Tim Gardner
2010-03-19 16:19       ` Thomas Jarosch
2010-03-19 16:32         ` Patrick McHardy
2010-03-19 16:38           ` Tim Gardner
2010-03-22 17:31         ` Patrick McHardy
2010-03-22 19:14           ` Thomas Jarosch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003191604.45719.thomas.jarosch@intra2net.com \
    --to=thomas.jarosch@intra2net.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=timg@tpi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).