From: Stephen Hemminger <shemminger@vyatta.com>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Patrick McHardy <kaber@trash.net>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] netfilter: cleanup printk messages
Date: Wed, 12 May 2010 09:54:29 -0700 [thread overview]
Message-ID: <20100512095429.18b10af7@nehalam> (raw)
In-Reply-To: <alpine.LSU.2.01.1005121851370.14663@obet.zrqbmnf.qr>
On Wed, 12 May 2010 18:52:02 +0200 (CEST)
Jan Engelhardt <jengelh@medozas.de> wrote:
>
> On Wednesday 2010-05-12 18:29, Stephen Hemminger wrote:
>
> >Make sure all printk messages have a severity level.
> >
> >--- a/net/netfilter/nf_conntrack_amanda.c 2010-05-12 09:28:26.447006714 -0700
> >+++ b/net/netfilter/nf_conntrack_amanda.c 2010-05-12 09:28:44.287371327 -0700
> >@@ -108,7 +108,7 @@ static int amanda_help(struct sk_buff *s
> > dataoff = protoff + sizeof(struct udphdr);
> > if (dataoff >= skb->len) {
> > if (net_ratelimit())
> >- printk("amanda_help: skblen = %u\n", skb->len);
> >+ printk(KERN_ERR "amanda_help: skblen = %u\n", skb->len);
>
> A good idea, but perhaps we should just use pr_{err,andsoon} while at it.
I did some places, but code that was already using printk(KERN_XXX form,
I just duplicated existing style in that file.
--
next prev parent reply other threads:[~2010-05-12 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100512162954.316178344@vyatta.com>
2010-05-12 16:29 ` [PATCH 1/2] netfilter: change NF_ASSERT to WARN_ON Stephen Hemminger
2010-05-13 13:01 ` Patrick McHardy
2010-05-12 16:29 ` [PATCH 2/2] netfilter: cleanup printk messages Stephen Hemminger
2010-05-12 16:52 ` Jan Engelhardt
2010-05-12 16:54 ` Stephen Hemminger [this message]
2010-05-13 13:03 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512095429.18b10af7@nehalam \
--to=shemminger@vyatta.com \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).