netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] netfilter: xt_TEE depends on NF_CONNTRACK
       [not found] <20100514161407.740da901.sfr@canb.auug.org.au>
@ 2010-05-14 17:12 ` Randy Dunlap
  2010-05-14 17:20   ` Patrick McHardy
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2010-05-14 17:12 UTC (permalink / raw)
  To: Stephen Rothwell, netdev, Jan Engelhardt, netfilter-devel
  Cc: linux-next, LKML, Patrick McHardy

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix xt_TEE build for the case of NF_CONNTRACK=m and
NETFILTER_XT_TARGET_TEE=y:

xt_TEE.c:(.text+0x6df5c): undefined reference to `nf_conntrack_untracked'
4x

Built with all 4 m/y combinations.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc:	Patrick McHardy <kaber@trash.net>
Cc:	Jan Engelhardt <jengelh@medozas.de>
---
 net/netfilter/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20100514.orig/net/netfilter/Kconfig
+++ linux-next-20100514/net/netfilter/Kconfig
@@ -506,6 +506,7 @@ config NETFILTER_XT_TARGET_TEE
 	tristate '"TEE" - packet cloning to alternate destiantion'
 	depends on NETFILTER_ADVANCED
 	depends on (IPV6 || IPV6=n)
+	depends on !NF_CONNTRACK || NF_CONNTRACK
 	---help---
 	This option adds a "TEE" target with which a packet can be cloned and
 	this clone be rerouted to another nexthop.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] netfilter: xt_TEE depends on NF_CONNTRACK
  2010-05-14 17:12 ` [PATCH -next] netfilter: xt_TEE depends on NF_CONNTRACK Randy Dunlap
@ 2010-05-14 17:20   ` Patrick McHardy
  2010-05-14 20:52     ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Patrick McHardy @ 2010-05-14 17:20 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Stephen Rothwell, netdev, Jan Engelhardt, netfilter-devel,
	linux-next, LKML, David S. Miller

Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix xt_TEE build for the case of NF_CONNTRACK=m and
> NETFILTER_XT_TARGET_TEE=y:
> 
> xt_TEE.c:(.text+0x6df5c): undefined reference to `nf_conntrack_untracked'
> 4x
> 
> Built with all 4 m/y combinations.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc:	Patrick McHardy <kaber@trash.net>
> Cc:	Jan Engelhardt <jengelh@medozas.de>

Acked-by: Patrick McHardy <kaber@trash.net>

Dave, please apply directly. Thanks!

> ---
>  net/netfilter/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20100514.orig/net/netfilter/Kconfig
> +++ linux-next-20100514/net/netfilter/Kconfig
> @@ -506,6 +506,7 @@ config NETFILTER_XT_TARGET_TEE
>  	tristate '"TEE" - packet cloning to alternate destiantion'
>  	depends on NETFILTER_ADVANCED
>  	depends on (IPV6 || IPV6=n)
> +	depends on !NF_CONNTRACK || NF_CONNTRACK
>  	---help---
>  	This option adds a "TEE" target with which a packet can be cloned and
>  	this clone be rerouted to another nexthop.
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] netfilter: xt_TEE depends on NF_CONNTRACK
  2010-05-14 17:20   ` Patrick McHardy
@ 2010-05-14 20:52     ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-05-14 20:52 UTC (permalink / raw)
  To: kaber
  Cc: randy.dunlap, sfr, netdev, jengelh, netfilter-devel, linux-next,
	linux-kernel

From: Patrick McHardy <kaber@trash.net>
Date: Fri, 14 May 2010 19:20:16 +0200

> Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>> 
>> Fix xt_TEE build for the case of NF_CONNTRACK=m and
>> NETFILTER_XT_TARGET_TEE=y:
>> 
>> xt_TEE.c:(.text+0x6df5c): undefined reference to `nf_conntrack_untracked'
>> 4x
>> 
>> Built with all 4 m/y combinations.
>> 
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc:	Patrick McHardy <kaber@trash.net>
>> Cc:	Jan Engelhardt <jengelh@medozas.de>
> 
> Acked-by: Patrick McHardy <kaber@trash.net>
> 
> Dave, please apply directly. Thanks!

Done, thanks everyone.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-05-14 20:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20100514161407.740da901.sfr@canb.auug.org.au>
2010-05-14 17:12 ` [PATCH -next] netfilter: xt_TEE depends on NF_CONNTRACK Randy Dunlap
2010-05-14 17:20   ` Patrick McHardy
2010-05-14 20:52     ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).