From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
Patrick McHardy <kaber@trash.net>
Subject: [PATCHv2] netfilter: Remove skb_is_nonlinear check from nf_conntrack_sip
Date: Fri, 14 May 2010 12:01:38 -0600 [thread overview]
Message-ID: <20100514180138.GF15969@obsidianresearch.com> (raw)
At least the XEN net front driver always produces non linear skbs,
so the SIP module does nothing at all when used with that NIC.
Unconditionally linearize the skb..
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
---
net/netfilter/nf_conntrack_sip.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
Patrick/Jan, thanks.. This is what I wanted to do in the first place,
but I couldn't convince myself it was safe, as no other nf code does
this..
Unfortunately I can no longer test it :(
diff --git a/net/netfilter/nf_conntrack_sip.c b/net/netfilter/nf_conntrack_sip.c
index 4b57216..02d0b59 100644
--- a/net/netfilter/nf_conntrack_sip.c
+++ b/net/netfilter/nf_conntrack_sip.c
@@ -1275,13 +1275,10 @@ static int sip_help(struct sk_buff *skb,
nf_ct_refresh(ct, skb, sip_timeout * HZ);
- if (!skb_is_nonlinear(skb))
- dptr = skb->data + dataoff;
- else {
- pr_debug("Copy of skbuff not supported yet.\n");
- return NF_ACCEPT;
- }
+ if (unlikely(skb_linearize(skb)))
+ return NF_DROP;
+ dptr = skb->data + dataoff;
datalen = skb->len - dataoff;
if (datalen < strlen("SIP/2.0 200"))
return NF_ACCEPT;
--
1.6.0.4
next reply other threads:[~2010-05-14 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 18:01 Jason Gunthorpe [this message]
2010-05-14 18:13 ` [PATCHv2] netfilter: Remove skb_is_nonlinear check from nf_conntrack_sip Patrick McHardy
2010-05-14 18:26 ` Jason Gunthorpe
2010-05-14 18:42 ` Patrick McHardy
2010-05-14 19:26 ` Patrick McHardy
2010-05-14 19:33 ` Jan Engelhardt
2010-05-14 19:41 ` Patrick McHardy
2010-05-14 19:56 ` Jason Gunthorpe
2010-05-14 18:33 ` Jan Engelhardt
2010-05-14 18:45 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514180138.GF15969@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).