[PATCHv2] extensions: libxt_CHECKSUM extension

[PATCHv2] extensions: libxt_CHECKSUM extension

[Michael S. Tsirkin]

This adds a `CHECKSUM' target, which can be used in the iptables mangle
table.

You can use this target to compute and fill in the checksum in
a packet that lacks a checksum.  This is particularly useful,
if you need to work around old applications such as dhcp clients,
that do not work well with checksum offloads, but don't want to disable
checksum offload in your device.

The problem happens in the field with virtualized applications.
For reference, see Red Hat bz 605555, as well as
http://www.spinics.net/lists/kvm/msg37660.html

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---

Changes from v1:
	switched from ipt to xt target

 extensions/libipt_CHECKSUM.man |    8 +++
 extensions/libxt_CHECKSUM.c    |   99 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 107 insertions(+), 0 deletions(-)
 create mode 100644 extensions/libipt_CHECKSUM.man
 create mode 100644 extensions/libxt_CHECKSUM.c

diff --git a/extensions/libipt_CHECKSUM.man b/extensions/libipt_CHECKSUM.man
new file mode 100644
index 0000000..4f83335
--- /dev/null
+++ b/extensions/libipt_CHECKSUM.man
@@ -0,0 +1,8 @@
+This target allows to selectively work around broken/old applications.
+It can only be used in the mangle table.
+.TP
+\fB\-\-checksum\-fill\fP
+Compute and fill in the checksum in a packet that lacks a checksum.
+This is particularly useful, if you need to work around old applications
+such as dhcp clients, that do not work well with checksum offloads,
+but don't want to disable checksum offload in your device.
diff --git a/extensions/libxt_CHECKSUM.c b/extensions/libxt_CHECKSUM.c
new file mode 100644
index 0000000..00fbd8f
--- /dev/null
+++ b/extensions/libxt_CHECKSUM.c
@@ -0,0 +1,99 @@
+/* Shared library add-on to xtables for CHECKSUM
+ *
+ * (C) 2002 by Harald Welte <laforge@gnumonks.org>
+ * (C) 2010 by Red Hat, Inc
+ * Author: Michael S. Tsirkin <mst@redhat.com>
+ *
+ * This program is distributed under the terms of GNU GPL v2, 1991
+ *
+ * libxt_CHECKSUM.c borrowed some bits from libipt_ECN.c
+ *
+ * $Id$
+ */
+#include <stdio.h>
+#include <string.h>
+#include <stdlib.h>
+#include <getopt.h>
+
+#include <xtables.h>
+#include <linux/netfilter/xt_CHECKSUM.h>
+
+static void CHECKSUM_help(void)
+{
+	printf(
+"CHECKSUM target options\n"
+"  --checksum-fill			Fill in packet checksum.\n");
+}
+
+static const struct option CHECKSUM_opts[] = {
+	{ "checksum-fill", 0, NULL, 'F' },
+	{ .name = NULL }
+};
+
+static int CHECKSUM_parse(int c, char **argv, int invert, unsigned int *flags,
+                     const void *entry, struct xt_entry_target **target)
+{
+	struct xt_CHECKSUM_info *einfo
+		= (struct xt_CHECKSUM_info *)(*target)->data;
+
+	switch (c) {
+	case 'F':
+		if (*flags)
+			xtables_error(PARAMETER_PROBLEM,
+			        "CHECKSUM target: Only use --checksum-fill ONCE!");
+		einfo->operation = XT_CHECKSUM_OP_FILL;
+		*flags |= XT_CHECKSUM_OP_FILL;
+		break;
+	default:
+		return 0;
+	}
+
+	return 1;
+}
+
+static void CHECKSUM_check(unsigned int flags)
+{
+	if (!flags)
+		xtables_error(PARAMETER_PROBLEM,
+		           "CHECKSUM target: Parameter --checksum-fill is required");
+}
+
+static void CHECKSUM_print(const void *ip, const struct xt_entry_target *target,
+                      int numeric)
+{
+	const struct xt_CHECKSUM_info *einfo =
+		(const struct xt_CHECKSUM_info *)target->data;
+
+	printf("CHECKSUM ");
+
+	if (einfo->operation & XT_CHECKSUM_OP_FILL)
+		printf("fill ");
+}
+
+static void CHECKSUM_save(const void *ip, const struct xt_entry_target *target)
+{
+	const struct xt_CHECKSUM_info *einfo =
+		(const struct xt_CHECKSUM_info *)target->data;
+
+	if (einfo->operation & XT_CHECKSUM_OP_FILL)
+		printf("--checksum-fill ");
+}
+
+static struct xtables_target checksum_tg_reg = {
+	.name		= "CHECKSUM",
+	.version	= XTABLES_VERSION,
+	.family		= NFPROTO_UNSPEC,
+	.size		= XT_ALIGN(sizeof(struct xt_CHECKSUM_info)),
+	.userspacesize	= XT_ALIGN(sizeof(struct xt_CHECKSUM_info)),
+	.help		= CHECKSUM_help,
+	.parse		= CHECKSUM_parse,
+	.final_check	= CHECKSUM_check,
+	.print		= CHECKSUM_print,
+	.save		= CHECKSUM_save,
+	.extra_opts	= CHECKSUM_opts,
+};
+
+void _init(void)
+{
+	xtables_register_target(&checksum_tg_reg);
+}

[PATCHv3] extensions: libxt_CHECKSUM extension

[Michael S. Tsirkin]

This adds a `CHECKSUM' target, which can be used in the iptables mangle
table.

You can use this target to compute and fill in the checksum in
a packet that lacks a checksum.  This is particularly useful,
if you need to work around old applications such as dhcp clients,
that do not work well with checksum offloads, but don't want to disable
checksum offload in your device.

The problem happens in the field with virtualized applications.
For reference, see Red Hat bz 605555, as well as
http://www.spinics.net/lists/kvm/msg37660.html

Typical expected use (helps old dhclient binary running in a VM):
iptables -A POSTROUTING -t mangle -p udp --dport bootpc \
        -j CHECKSUM --checksum-fill

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---

Correction in the documentation. Sorry about the noise.

Changes from v2:
	updated man file
Changes from v1:
	switched from ipt to xt

 extensions/libxt_CHECKSUM.c   |   99 +++++++++++++++++++++++++++++++++++++++++
 extensions/libxt_CHECKSUM.man |    8 +++
 2 files changed, 107 insertions(+), 0 deletions(-)
 create mode 100644 extensions/libxt_CHECKSUM.c
 create mode 100644 extensions/libxt_CHECKSUM.man

diff --git a/extensions/libxt_CHECKSUM.c b/extensions/libxt_CHECKSUM.c
new file mode 100644
index 0000000..00fbd8f
--- /dev/null
+++ b/extensions/libxt_CHECKSUM.c
@@ -0,0 +1,99 @@
+/* Shared library add-on to xtables for CHECKSUM
+ *
+ * (C) 2002 by Harald Welte <laforge@gnumonks.org>
+ * (C) 2010 by Red Hat, Inc
+ * Author: Michael S. Tsirkin <mst@redhat.com>
+ *
+ * This program is distributed under the terms of GNU GPL v2, 1991
+ *
+ * libxt_CHECKSUM.c borrowed some bits from libipt_ECN.c
+ *
+ * $Id$
+ */
+#include <stdio.h>
+#include <string.h>
+#include <stdlib.h>
+#include <getopt.h>
+
+#include <xtables.h>
+#include <linux/netfilter/xt_CHECKSUM.h>
+
+static void CHECKSUM_help(void)
+{
+	printf(
+"CHECKSUM target options\n"
+"  --checksum-fill			Fill in packet checksum.\n");
+}
+
+static const struct option CHECKSUM_opts[] = {
+	{ "checksum-fill", 0, NULL, 'F' },
+	{ .name = NULL }
+};
+
+static int CHECKSUM_parse(int c, char **argv, int invert, unsigned int *flags,
+                     const void *entry, struct xt_entry_target **target)
+{
+	struct xt_CHECKSUM_info *einfo
+		= (struct xt_CHECKSUM_info *)(*target)->data;
+
+	switch (c) {
+	case 'F':
+		if (*flags)
+			xtables_error(PARAMETER_PROBLEM,
+			        "CHECKSUM target: Only use --checksum-fill ONCE!");
+		einfo->operation = XT_CHECKSUM_OP_FILL;
+		*flags |= XT_CHECKSUM_OP_FILL;
+		break;
+	default:
+		return 0;
+	}
+
+	return 1;
+}
+
+static void CHECKSUM_check(unsigned int flags)
+{
+	if (!flags)
+		xtables_error(PARAMETER_PROBLEM,
+		           "CHECKSUM target: Parameter --checksum-fill is required");
+}
+
+static void CHECKSUM_print(const void *ip, const struct xt_entry_target *target,
+                      int numeric)
+{
+	const struct xt_CHECKSUM_info *einfo =
+		(const struct xt_CHECKSUM_info *)target->data;
+
+	printf("CHECKSUM ");
+
+	if (einfo->operation & XT_CHECKSUM_OP_FILL)
+		printf("fill ");
+}
+
+static void CHECKSUM_save(const void *ip, const struct xt_entry_target *target)
+{
+	const struct xt_CHECKSUM_info *einfo =
+		(const struct xt_CHECKSUM_info *)target->data;
+
+	if (einfo->operation & XT_CHECKSUM_OP_FILL)
+		printf("--checksum-fill ");
+}
+
+static struct xtables_target checksum_tg_reg = {
+	.name		= "CHECKSUM",
+	.version	= XTABLES_VERSION,
+	.family		= NFPROTO_UNSPEC,
+	.size		= XT_ALIGN(sizeof(struct xt_CHECKSUM_info)),
+	.userspacesize	= XT_ALIGN(sizeof(struct xt_CHECKSUM_info)),
+	.help		= CHECKSUM_help,
+	.parse		= CHECKSUM_parse,
+	.final_check	= CHECKSUM_check,
+	.print		= CHECKSUM_print,
+	.save		= CHECKSUM_save,
+	.extra_opts	= CHECKSUM_opts,
+};
+
+void _init(void)
+{
+	xtables_register_target(&checksum_tg_reg);
+}
diff --git a/extensions/libxt_CHECKSUM.man b/extensions/libxt_CHECKSUM.man
new file mode 100644
index 0000000..92ae700
--- /dev/null
+++ b/extensions/libxt_CHECKSUM.man
@@ -0,0 +1,8 @@
+This target allows to selectively work around broken/old applications.
+It can only be used in the mangle table.
+.TP
+\fB\-\-checksum\-fill\fP
+Compute and fill in the checksum in a packet that lacks a checksum.
+This is particularly useful, if you need to work around old applications
+such as dhcp clients, that do not work well with checksum offloads,
+but don't want to disable checksum offload in your device.
-- 
1.7.2.rc0.14.g41c1c

Re: [PATCHv2] netfilter: add CHECKSUM target

[Patrick McHardy]

Am 11.07.2010 17:06, schrieb Michael S. Tsirkin:
> +#ifndef _IPT_CHECKSUM_TARGET_H
> +#define _IPT_CHECKSUM_TARGET_H
> +
> +#define XT_CHECKSUM_OP_FILL	0x01	/* fill in checksum in IP header */
> +
> +struct xt_CHECKSUM_info {
> +	u_int8_t operation;	/* bitset of operations */

Please use __u8 in public header files.

> +};
> +
> +#endif /* _IPT_CHECKSUM_TARGET_H */
> diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
> index 8593a77..1cf4852 100644
> --- a/net/netfilter/Kconfig
> +++ b/net/netfilter/Kconfig
> @@ -294,7 +294,7 @@ endif # NF_CONNTRACK
>  config NETFILTER_TPROXY
>  	tristate "Transparent proxying support (EXPERIMENTAL)"
>  	depends on EXPERIMENTAL
> -	depends on IP_NF_MANGLE
> +	depends on IP_NF_MANGLE || IP6_NF_MANGLE

This does not seem to belong into this patch.

>  	depends on NETFILTER_ADVANCED
>  	help
>  	  This option enables transparent proxying support, that is,
> @@ -347,6 +347,21 @@ config NETFILTER_XT_CONNMARK
>  
>  comment "Xtables targets"
>  
> +config NETFILTER_XT_TARGET_CHECKSUM
> +	tristate "CHECKSUM target support"
> +	depends on NETFILTER_ADVANCED
> +	---help---
> +	  This option adds a `CHECKSUM' target, which can be used in the iptables mangle
> +	  table.  

You should add a dependency on the mangle table then.

> +
> +	  You can use this target to compute and fill in the checksum in
> +	  a packet that lacks a checksum.  This is particularly useful,
> +	  if you need to work around old applications such as dhcp clients,
> +	  that do not work well with checksum offloads, but don't want to disable
> +	  checksum offload in your device.
> +
> +	  To compile it as a module, choose M here.  If unsure, say N.
> +
>  config NETFILTER_XT_TARGET_CLASSIFY
>  	tristate '"CLASSIFY" target support'
>  	depends on NETFILTER_ADVANCED
> diff --git a/net/netfilter/Makefile b/net/netfilter/Makefile
> index 14e3a8f..8eb541d 100644
> --- a/net/netfilter/Makefile
> +++ b/net/netfilter/Makefile
> @@ -45,6 +45,7 @@ obj-$(CONFIG_NETFILTER_XT_MARK) += xt_mark.o
>  obj-$(CONFIG_NETFILTER_XT_CONNMARK) += xt_connmark.o
>  
>  # targets
> +obj-$(CONFIG_NETFILTER_XT_TARGET_CHECKSUM) += xt_CHECKSUM.o
>  obj-$(CONFIG_NETFILTER_XT_TARGET_CLASSIFY) += xt_CLASSIFY.o
>  obj-$(CONFIG_NETFILTER_XT_TARGET_CONNSECMARK) += xt_CONNSECMARK.o
>  obj-$(CONFIG_NETFILTER_XT_TARGET_CT) += xt_CT.o
> diff --git a/net/netfilter/xt_CHECKSUM.c b/net/netfilter/xt_CHECKSUM.c
> new file mode 100644
> index 0000000..0fee1a7
> --- /dev/null
> +++ b/net/netfilter/xt_CHECKSUM.c
> @@ -0,0 +1,72 @@
> +/* iptables module for the packet checksum mangling
> + *
> + * (C) 2002 by Harald Welte <laforge@netfilter.org>
> + * (C) 2010 Red Hat, Inc.
> + *
> + * Author: Michael S. Tsirkin <mst@redhat.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +#include <linux/in.h>

Do you really need in.h?

> +#include <linux/module.h>
> +#include <linux/skbuff.h>
> +#include <linux/netdevice.h>
> +
> +#include <linux/netfilter/x_tables.h>
> +#include <linux/netfilter/xt_CHECKSUM.h>
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Michael S. Tsirkin <mst@redhat.com>");
> +MODULE_DESCRIPTION("Xtables: checksum modification");
> +MODULE_ALIAS("ipt_CHECKSUM");
> +MODULE_ALIAS("ip6t_CHECKSUM");
> +
> +static unsigned int
> +checksum_tg(struct sk_buff *skb, const struct xt_action_param *par)
> +{
> +	if (skb->ip_summed == CHECKSUM_PARTIAL)
> +		skb_checksum_help(skb);
> +
> +	return XT_CONTINUE;
> +}
> +
> +static int checksum_tg_check(const struct xt_tgchk_param *par)
> +{
> +	const struct xt_CHECKSUM_info *einfo = par->targinfo;
> +
> +	if (einfo->operation & ~XT_CHECKSUM_OP_FILL) {
> +		pr_info("unsupported CHECKSUM operation %x\n", einfo->operation);
> +		return -EINVAL;
> +	}
> +	if (!einfo->operation) {
> +		pr_info("no CHECKSUM operation enabled\n");
> +		return -EINVAL;
> +	}
> +	return 0;
> +}
> +
> +static struct xt_target checksum_tg_reg __read_mostly = {
> +	.name		= "CHECKSUM",
> +	.family		= NFPROTO_UNSPEC,
> +	.target		= checksum_tg,
> +	.targetsize	= sizeof(struct xt_CHECKSUM_info),
> +	.table		= "mangle",
> +	.checkentry	= checksum_tg_check,
> +	.me		= THIS_MODULE,
> +};
> +
> +static int __init checksum_tg_init(void)
> +{
> +	return xt_register_target(&checksum_tg_reg);
> +}
> +
> +static void __exit checksum_tg_exit(void)
> +{
> +	xt_unregister_target(&checksum_tg_reg);
> +}
> +
> +module_init(checksum_tg_init);
> +module_exit(checksum_tg_exit);

Re: [PATCHv2] extensions: libxt_CHECKSUM extension

[Jan Engelhardt]

>This adds a `CHECKSUM' target, which can be used in the iptables mangle 
>table.
>
>You can use this target to compute and fill in the checksum in a packet 
>that lacks a checksum.  This is particularly useful, if you need to 
>work around old applications such as dhcp clients, that do not work 
>well with checksum offloads, but don't want to disable checksum offload 
>in your device.
>
>The problem happens in the field with virtualized applications. For 
>reference, see Red Hat bz 605555, as well as 
>http://www.spinics.net/lists/kvm/msg37660.html

Added to Xtables-addons.

Re: [PATCHv2] extensions: libxt_CHECKSUM extension

[Michael S. Tsirkin]

On Sun, Jul 11, 2010 at 05:57:07PM +0200, Jan Engelhardt wrote:
> 
> >This adds a `CHECKSUM' target, which can be used in the iptables mangle 
> >table.
> >
> >You can use this target to compute and fill in the checksum in a packet 
> >that lacks a checksum.  This is particularly useful, if you need to 
> >work around old applications such as dhcp clients, that do not work 
> >well with checksum offloads, but don't want to disable checksum offload 
> >in your device.
> >
> >The problem happens in the field with virtualized applications. For 
> >reference, see Red Hat bz 605555, as well as 
> >http://www.spinics.net/lists/kvm/msg37660.html
> 
> Added to Xtables-addons.

Please do not drop the explanation that bits were copied from ECN.c.

-- 
MST

Re: [PATCHv2] extensions: libxt_CHECKSUM extension

[Jan Engelhardt]

On Sunday 2010-07-11 21:00, Michael S. Tsirkin wrote:
>> >
>> >The problem happens in the field with virtualized applications. For 
>> >reference, see Red Hat bz 605555, as well as 
>> >http://www.spinics.net/lists/kvm/msg37660.html
>> 
>> Added to Xtables-addons.
>
>Please do not drop the explanation that bits were copied from ECN.c.

As far as I see it, there is nothing that deals with ECN in any way.

Re: [PATCHv2] extensions: libxt_CHECKSUM extension

[Michael S. Tsirkin]

On Sun, Jul 11, 2010 at 09:54:32PM +0200, Jan Engelhardt wrote:
> 
> On Sunday 2010-07-11 21:00, Michael S. Tsirkin wrote:
> >> >
> >> >The problem happens in the field with virtualized applications. For 
> >> >reference, see Red Hat bz 605555, as well as 
> >> >http://www.spinics.net/lists/kvm/msg37660.html
> >> 
> >> Added to Xtables-addons.
> >
> >Please do not drop the explanation that bits were copied from ECN.c.
> 
> As far as I see it, there is nothing that deals with ECN in any way.

No, the bits I copied deal with libxt boilerplate.

-- 
MST

Re: [PATCHv2] extensions: libxt_CHECKSUM extension

[Jan Engelhardt]

On Sunday 2010-07-11 21:52, Michael S. Tsirkin wrote:
>> On Sunday 2010-07-11 21:00, Michael S. Tsirkin wrote:
>> >> >
>> >> >The problem happens in the field with virtualized applications. For 
>> >> >reference, see Red Hat bz 605555, as well as 
>> >> >http://www.spinics.net/lists/kvm/msg37660.html
>> >> 
>> >> Added to Xtables-addons.
>> >
>> >Please do not drop the explanation that bits were copied from ECN.c.
>> 
>> As far as I see it, there is nothing that deals with ECN in any way.
>
>No, the bits I copied deal with libxt boilerplate.

Falls into the category of triviality, doesn't reach a level of originality.

Re: [PATCHv2] extensions: libxt_CHECKSUM extension

[Michael S. Tsirkin]

On Sun, Jul 11, 2010 at 10:03:44PM +0200, Jan Engelhardt wrote:
> 
> On Sunday 2010-07-11 21:52, Michael S. Tsirkin wrote:
> >> On Sunday 2010-07-11 21:00, Michael S. Tsirkin wrote:
> >> >> >
> >> >> >The problem happens in the field with virtualized applications. For 
> >> >> >reference, see Red Hat bz 605555, as well as 
> >> >> >http://www.spinics.net/lists/kvm/msg37660.html
> >> >> 
> >> >> Added to Xtables-addons.
> >> >
> >> >Please do not drop the explanation that bits were copied from ECN.c.
> >> 
> >> As far as I see it, there is nothing that deals with ECN in any way.
> >
> >No, the bits I copied deal with libxt boilerplate.
> 
> Falls into the category of triviality, doesn't reach a level of originality.

In that case the 2002 copyright doesn't need to be there as well?

-- 
MST

Re: [PATCHv2] extensions: libxt_CHECKSUM extension

[Jan Engelhardt]

On Sunday 2010-07-11 22:00, Michael S. Tsirkin wrote:
>> >> As far as I see it, there is nothing that deals with ECN in any way.
>> >
>> >No, the bits I copied deal with libxt boilerplate.
>> 
>> Falls into the category of triviality, doesn't reach a level of originality.
>
>In that case the 2002 copyright doesn't need to be there as well?

Perhaps, but IANAL.

Re: [PATCHv2] extensions: libxt_CHECKSUM extension

[Michael S. Tsirkin]

On Mon, Jul 12, 2010 at 07:12:56PM +0200, Jan Engelhardt wrote:
> On Sunday 2010-07-11 22:00, Michael S. Tsirkin wrote:
> >> >> As far as I see it, there is nothing that deals with ECN in any way.
> >> >
> >> >No, the bits I copied deal with libxt boilerplate.
> >> 
> >> Falls into the category of triviality, doesn't reach a level of originality.
> >
> >In that case the 2002 copyright doesn't need to be there as well?
> 
> Perhaps, but IANAL.

I put it there because of the copied bits. If you say they are trivial,
strip that off, if not, better keep the attribution as well.

-- 
MST

Re: [PATCHv2] extensions: libxt_CHECKSUM extension

[Michael S. Tsirkin]

On Sun, Jul 11, 2010 at 05:57:07PM +0200, Jan Engelhardt wrote:
> 
> >This adds a `CHECKSUM' target, which can be used in the iptables mangle 
> >table.
> >
> >You can use this target to compute and fill in the checksum in a packet 
> >that lacks a checksum.  This is particularly useful, if you need to 
> >work around old applications such as dhcp clients, that do not work 
> >well with checksum offloads, but don't want to disable checksum offload 
> >in your device.
> >
> >The problem happens in the field with virtualized applications. For 
> >reference, see Red Hat bz 605555, as well as 
> >http://www.spinics.net/lists/kvm/msg37660.html
> 
> Added to Xtables-addons.

Looks like .man file is missing. Intentional?
It's there in v3 of the patch.

-- 
MST

Re: [PATCHv2] extensions: libxt_CHECKSUM extension

[Jan Engelhardt]

On Sunday 2010-07-11 21:06, Michael S. Tsirkin wrote:
>> >
>> >The problem happens in the field with virtualized applications. For 
>> >reference, see Red Hat bz 605555, as well as 
>> >http://www.spinics.net/lists/kvm/msg37660.html
>> 
>> Added to Xtables-addons.
>
>Looks like .man file is missing. Intentional?
>It's there in v3 of the patch.

21:57 yaguchi:../addons/extensions > l *CHEC*
-rw-r--r-- 1 jengelh users 2358 Jul 11 21:29 libxt_CHECKSUM.c
-rw-r--r-- 1 jengelh users  409 Jul 11 21:29 libxt_CHECKSUM.man
-rw-r--r-- 1 jengelh users 1862 Jul 11 21:29 xt_CHECKSUM.c
-rw-r--r-- 1 jengelh users  481 Jul 11 21:29 xt_CHECKSUM.h

Re: [PATCHv2] extensions: libxt_CHECKSUM extension

[Michael S. Tsirkin]

On Sun, Jul 11, 2010 at 09:57:51PM +0200, Jan Engelhardt wrote:
> 
> On Sunday 2010-07-11 21:06, Michael S. Tsirkin wrote:
> >> >
> >> >The problem happens in the field with virtualized applications. For 
> >> >reference, see Red Hat bz 605555, as well as 
> >> >http://www.spinics.net/lists/kvm/msg37660.html
> >> 
> >> Added to Xtables-addons.
> >
> >Looks like .man file is missing. Intentional?
> >It's there in v3 of the patch.
> 
> 21:57 yaguchi:../addons/extensions > l *CHEC*
> -rw-r--r-- 1 jengelh users 2358 Jul 11 21:29 libxt_CHECKSUM.c
> -rw-r--r-- 1 jengelh users  409 Jul 11 21:29 libxt_CHECKSUM.man
> -rw-r--r-- 1 jengelh users 1862 Jul 11 21:29 xt_CHECKSUM.c
> -rw-r--r-- 1 jengelh users  481 Jul 11 21:29 xt_CHECKSUM.h

See it now. Sorry about the noise.

Re: [PATCHv3] extensions: libxt_CHECKSUM extension

[Patrick McHardy]

Am 11.07.2010 17:14, schrieb Michael S. Tsirkin:
> diff --git a/extensions/libxt_CHECKSUM.c b/extensions/libxt_CHECKSUM.c
> new file mode 100644
> index 0000000..00fbd8f
> --- /dev/null
> +++ b/extensions/libxt_CHECKSUM.c
> @@ -0,0 +1,99 @@
> +/* Shared library add-on to xtables for CHECKSUM
> + *
> + * (C) 2002 by Harald Welte <laforge@gnumonks.org>
> + * (C) 2010 by Red Hat, Inc
> + * Author: Michael S. Tsirkin <mst@redhat.com>
> + *
> + * This program is distributed under the terms of GNU GPL v2, 1991
> + *
> + * libxt_CHECKSUM.c borrowed some bits from libipt_ECN.c
> + *
> + * $Id$

Please no CVS IDs.

> + */
> +#include <stdio.h>
> +#include <string.h>
> +#include <stdlib.h>
> +#include <getopt.h>
> +
> +#include <xtables.h>
> +#include <linux/netfilter/xt_CHECKSUM.h>
> +
> +static void CHECKSUM_help(void)
> +{
> +	printf(
> +"CHECKSUM target options\n"
> +"  --checksum-fill			Fill in packet checksum.\n");
> +}
> +
> +static const struct option CHECKSUM_opts[] = {
> +	{ "checksum-fill", 0, NULL, 'F' },
> +	{ .name = NULL }
> +};
> +
> +static int CHECKSUM_parse(int c, char **argv, int invert, unsigned int *flags,
> +                     const void *entry, struct xt_entry_target **target)
> +{
> +	struct xt_CHECKSUM_info *einfo
> +		= (struct xt_CHECKSUM_info *)(*target)->data;
> +
> +	switch (c) {
> +	case 'F':
> +		if (*flags)
> +			xtables_error(PARAMETER_PROBLEM,
> +			        "CHECKSUM target: Only use --checksum-fill ONCE!");

There is a helper function called xtables_param_act for checking double
arguments and printing a standarized error message.

> +		einfo->operation = XT_CHECKSUM_OP_FILL;
> +		*flags |= XT_CHECKSUM_OP_FILL;
> +		break;
> +	default:
> +		return 0;
> +	}
> +
> +	return 1;
> +}
> +

Re: several messages

[Jan Engelhardt]

On Thursday 2010-07-15 11:36, Patrick McHardy wrote:
>> +struct xt_CHECKSUM_info {
>> +	u_int8_t operation;	/* bitset of operations */
>
>Please use __u8 in public header files.
>
>> +#include <linux/in.h>
>
>Do you really need in.h?
>
>> + * $Id$
>
>Please no CVS IDs.
>
>> +	switch (c) {
>> +	case 'F':
>> +		if (*flags)
>> +			xtables_error(PARAMETER_PROBLEM,
>> +			        "CHECKSUM target: Only use --checksum-fill ONCE!");
>
>There is a helper function called xtables_param_act for checking double
>arguments and printing a standarized error message.

I took care of these for Xt-a.