From: David Miller <davem@davemloft.net>
To: stephen.buck@exinda.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, kaber@trash.net,
hidden@sch.bme.hu
Subject: Re: tproxy related crash in inet_hashtables
Date: Sat, 14 Aug 2010 22:16:11 -0700 (PDT) [thread overview]
Message-ID: <20100814.221611.15248639.davem@davemloft.net> (raw)
In-Reply-To: <4C661D09.8030709@exinda.com>
From: Stephen Buck <stephen.buck@exinda.com>
Date: Sat, 14 Aug 2010 14:35:21 +1000
> + }
> + if (!node)
> + tb = inet_bind_bucket_create(table->bind_bucket_cachep,
> + sock_net(sk), head, port);
> + }
> sk_add_bind_node(child, &tb->owners);
inet_bind_bucket_create() can fail due to memory allocation failure,
you're therefore going to have to find a way to handle that.
And in doing so you're going to find out that there is no easy
way out of this code path in such an error, this code was
absolutely not designed to be able to handle cases like this.
next prev parent reply other threads:[~2010-08-15 5:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C64FF2E.6060509@exinda.com>
2010-08-13 10:54 ` tproxy related crash in inet_hashtables Eric Dumazet
2010-08-13 13:05 ` Stephen Buck
2010-08-13 13:55 ` Eric Dumazet
2010-08-14 4:35 ` Stephen Buck
2010-08-15 5:16 ` David Miller [this message]
2010-08-16 8:26 ` Stephen Buck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100814.221611.15248639.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hidden@sch.bme.hu \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=stephen.buck@exinda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).