From: David Miller <davem@davemloft.net>
To: horms@verge.net.au
Cc: ja@ssi.bg, linux-kernel@vger.kernel.org,
lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
kaber@trash.net, tingsrain@gmail.com
Subject: Re: [patch nf-next] IPVS: ICMPv6 checksum calculation
Date: Tue, 17 Aug 2010 17:26:02 -0700 (PDT) [thread overview]
Message-ID: <20100817.172602.193696444.davem@davemloft.net> (raw)
In-Reply-To: <20100818002149.GA18114@verge.net.au>
From: Simon Horman <horms@verge.net.au>
Date: Wed, 18 Aug 2010 09:21:49 +0900
> [ CCing netdev for comment ]
>
> On Tue, Aug 17, 2010 at 12:25:56PM +0300, Julian Anastasov wrote:
...
>> May be ip_vs_checksum_complete() is not needed here?
>> Also, skb->csum is not valid for every ip_summed value.
>> May be we need to apply CHECKSUM_PARTIAL kind of setup for the IPv6.
>> Such example is net/ipv6/udp.c:udp6_ufo_send_check().
>> Later dev_queue_xmit() and skb_checksum_help() should take care
>> for the next steps. Something like this can be tested:
>>
>> icmph->icmp6_cksum = csum_ipv6_magic(&iph->saddr,
>> &iph->daddr,
>> skb->len - icmp_offset, IPPROTO_ICMPV6,
>> 0);
>> skb->csum_start = skb_network_header(skb) - skb->head +
>> icmp_offset;
>> skb->csum_offset = offsetof(struct icmp6hdr, icmp6_cksum);
>> skb->ip_summed = CHECKSUM_PARTIAL;
>>
Yes, using CHECKSUM_PARTIAL unconditionally would work.
next prev parent reply other threads:[~2010-08-18 0:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 7:00 [patch nf-next] IPVS: ICMPv6 checksum calculation Simon Horman
2010-08-17 9:25 ` Julian Anastasov
2010-08-18 0:21 ` Simon Horman
2010-08-18 0:26 ` David Miller [this message]
2010-08-18 4:20 ` xiaoyu Du
2010-08-18 5:57 ` Simon Horman
2010-08-20 11:14 ` xiaoyu Du
2010-08-20 13:48 ` Julian Anastasov
2010-08-23 2:54 ` xiaoyu Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817.172602.193696444.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=tingsrain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).