netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Mickler <florian@mickler.org>
To: David Miller <davem@davemloft.net>
Cc: fw@strlen.de, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH][RESEND] netfilter: fix CONFIG_COMPAT support
Date: Mon, 30 Aug 2010 16:10:37 +0200	[thread overview]
Message-ID: <20100830161037.517d6ea5@schatten.dmk.lab> (raw)
In-Reply-To: <20100823.144146.173873857.davem@davemloft.net>

On Mon, 23 Aug 2010 14:41:46 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: Florian Westphal <fw@strlen.de>
> Date: Mon, 23 Aug 2010 14:56:26 +0200
> 
> > commit f3c5c1bfd430858d3a05436f82c51e53104feb6b
> > (netfilter: xtables: make ip_tables reentrant) forgot to
> > also compute the jumpstack size in the compat handlers.
> > 
> > Result is that "iptables -I INPUT -j userchain" turns into -j DROP.
> > 
> > Reported by Sebastian Roesner on #netfilter, closes
> > http://bugzilla.netfilter.org/show_bug.cgi?id=669.
> > 
> > Note: arptables change is compile-tested only.
> > 
> > Signed-off-by: Florian Westphal <fw@strlen.de>
> > Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
> 
> Applied, thanks Florian.
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Should this go to stable? 
It seems commit f3c5c1bdf was introduced in 2.6.35.

It fixes 
	[Bug #16423] netfilter/iptables stopped logging 2.6.35-rc 
which was tracked as a regression.

Cheers,
Flo

  reply	other threads:[~2010-08-30 14:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-23 12:56 [PATCH][RESEND] netfilter: fix CONFIG_COMPAT support Florian Westphal
2010-08-23 21:41 ` David Miller
2010-08-30 14:10   ` Florian Mickler [this message]
2010-08-30 21:50     ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100830161037.517d6ea5@schatten.dmk.lab \
    --to=florian@mickler.org \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).