From: Simon Horman <horms@verge.net.au>
To: David Miller <davem@davemloft.net>
Cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, kaber@trash.net,
wensong@linux-vs.org, ja@ssi.bg
Subject: Re: [patch net] ipvs: fix active FTP
Date: Thu, 9 Sep 2010 09:27:48 +0900 [thread overview]
Message-ID: <20100909002743.GA5783@verge.net.au> (raw)
In-Reply-To: <20100908.104033.39195899.davem@davemloft.net>
On Wed, Sep 08, 2010 at 10:40:33AM -0700, David Miller wrote:
> From: Simon Horman <horms@verge.net.au>
> Date: Mon, 6 Sep 2010 13:02:29 +0900
>
> > From: Julian Anastasov <ja@ssi.bg>
> >
> > - Do not create expectation when forwarding the PORT
> > command to avoid blocking the connection. The problem is that
> > nf_conntrack_ftp.c:help() tries to create the same expectation later in
> > POST_ROUTING and drops the packet with "dropping packet" message after
> > failure in nf_ct_expect_related.
> >
> > - Change ip_vs_update_conntrack to alter the conntrack
> > for related connections from real server. If we do not alter the reply in
> > this direction the next packet from client sent to vport 20 comes as NEW
> > connection. We alter it but may be some collision happens for both
> > conntracks and the second conntrack gets destroyed immediately. The
> > connection stucks too.
> >
> > Signed-off-by: Julian Anastasov <ja@ssi.bg>
> > Signed-off-by: Simon Horman <horms@verge.net.au>
>
> Applied, thanks.
>
> > This change is also applicable to net-next, although there is some diff
> > noise. Do you want me to resolve that and post a net-next version
> > separately? (The same applies to "ipvs: avoid oops for passive FTP" which
> > you merged into net last week.)
>
> No need, the next time I merge net-2.6 into net-next-2.6 it will be
> taken care of transparently.
Great, thanks.
prev parent reply other threads:[~2010-09-09 0:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 4:02 [patch net] ipvs: fix active FTP Simon Horman
2010-09-08 17:40 ` David Miller
2010-09-09 0:27 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100909002743.GA5783@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=kaber@trash.net \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).