netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: KOVACS Krisztian <hidden@balabit.hu>
To: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Cc: Patrick McHardy <kaber@trash.net>, David Miller <davem@davemloft.net>
Subject: [PATCH 2/9] tproxy: added const specifiers to udp lookup functions
Date: Wed, 20 Oct 2010 13:21:18 +0200	[thread overview]
Message-ID: <20101020112118.6260.46933.stgit@este.odu> (raw)
In-Reply-To: <20101020112118.6260.31618.stgit@este.odu>

From: Balazs Scheidler <bazsi@balabit.hu>

The parameters for various UDP lookup functions were non-const, even though
they could be const. TProxy has some const references and instead of
downcasting it, I added const specifiers along the path.

Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>
Signed-off-by: KOVACS Krisztian <hidden@balabit.hu>
---
 net/ipv6/udp.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
index 5acb356..33e3683 100644
--- a/net/ipv6/udp.c
+++ b/net/ipv6/udp.c
@@ -122,8 +122,8 @@ static void udp_v6_rehash(struct sock *sk)
 
 static inline int compute_score(struct sock *sk, struct net *net,
 				unsigned short hnum,
-				struct in6_addr *saddr, __be16 sport,
-				struct in6_addr *daddr, __be16 dport,
+				const struct in6_addr *saddr, __be16 sport,
+				const struct in6_addr *daddr, __be16 dport,
 				int dif)
 {
 	int score = -1;
@@ -239,8 +239,8 @@ exact_match:
 }
 
 static struct sock *__udp6_lib_lookup(struct net *net,
-				      struct in6_addr *saddr, __be16 sport,
-				      struct in6_addr *daddr, __be16 dport,
+				      const struct in6_addr *saddr, __be16 sport,
+				      const struct in6_addr *daddr, __be16 dport,
 				      int dif, struct udp_table *udptable)
 {
 	struct sock *sk, *result;



  parent reply	other threads:[~2010-10-20 12:26 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-20 11:21 [PATCH 0/9] tproxy: add IPv6 support KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 6/9] tproxy: added IPv6 socket lookup function to nf_tproxy_core KOVACS Krisztian
2010-10-21  8:42   ` Jan Engelhardt
2010-10-21  9:48     ` KOVACS Krisztian
2010-10-20 11:21 ` KOVACS Krisztian [this message]
2010-10-20 11:21 ` [PATCH 7/9] tproxy: added IPv6 support to the TPROXY target KOVACS Krisztian
2010-10-21  8:47   ` Jan Engelhardt
2010-10-21  8:50     ` KOVACS Krisztian
2010-10-21  9:14       ` Jan Engelhardt
2010-10-21  9:33         ` KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 4/9] tproxy: added tproxy sockopt interface in the IPV6 layer KOVACS Krisztian
2010-10-21  8:39   ` Jan Engelhardt
2010-10-21  8:46     ` KOVACS Krisztian
2010-10-21 21:09       ` YOSHIFUJI Hideaki
2010-10-20 11:21 ` [PATCH 3/9] tproxy: added udp6_lib_lookup function KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 8/9] tproxy: added IPv6 support to the socket match KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 1/9] tproxy: split off ipv6 defragmentation to a separate module KOVACS Krisztian
2010-10-20 11:21 ` [PATCH 5/9] tproxy: allow non-local binds of IPv6 sockets if IP_TRANSPARENT is enabled KOVACS Krisztian
2010-10-20 12:45   ` YOSHIFUJI Hideaki
2010-10-20 14:07     ` Balazs Scheidler
2010-10-21 21:24       ` YOSHIFUJI Hideaki
2010-10-23 14:48         ` Balazs Scheidler
2010-10-24  5:03           ` YOSHIFUJI Hideaki
2010-10-24 23:08           ` David Miller
2010-10-20 11:21 ` [PATCH 9/9] tproxy: use the interface primary IP address as a default value for --on-ip KOVACS Krisztian
2010-10-21  9:12   ` Jan Engelhardt
2010-10-21 10:32     ` KOVACS Krisztian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101020112118.6260.46933.stgit@este.odu \
    --to=hidden@balabit.hu \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).