From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [RFC PATCH 5/9] ipvs network name space aware Date: Thu, 21 Oct 2010 16:34:35 +0200 Message-ID: <20101021143434.GA21739@verge.net.au> References: <201010081317.04167.hans.schillstrom@ericsson.com> <20101021111644.GA25555@verge.net.au> <1287660414.6871.85.camel@edumazet-laptop> <201010211349.25921.hans.schillstrom@ericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Eric Dumazet , "lvs-devel@vger.kernel.org" , "netdev@vger.kernel.org" , "netfilter-devel@vger.kernel.org" , "ja@ssi.bg" , "wensong@linux-vs.org" , "daniel.lezcano@free.fr" To: Hans Schillstrom Return-path: Content-Disposition: inline In-Reply-To: <201010211349.25921.hans.schillstrom@ericsson.com> Sender: netdev-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Thu, Oct 21, 2010 at 01:49:25PM +0200, Hans Schillstrom wrote: > On Thursday 21 October 2010 13:26:54 Eric Dumazet wrote: > > Le jeudi 21 octobre 2010 =C3=A0 13:16 +0200, Simon Horman a =C3=A9c= rit : > > > > > > @@ -2680,10 +2664,15 @@ static int ip_vs_genl_dump_services(str= uct sk_buff *skb, > > > > int idx =3D 0, i; > > > > int start =3D cb->args[0]; > > > > struct ip_vs_service *svc; > > > > - > > > > + struct net *net =3D skb->sk->sk_net; > > > > > > skb->sk->sk_net needs CONFIG_NS_NET. > > > Is your plan for IPVS to unconditionally depend on CONFIG_NS_NET? > > > It would be nice to avoid that, but I fear it will be too messy. > > > > > > > > > struct net *net =3D sock_net(skb->sk); > > > > is your friend ;) > > > > > Tanks Eric, >=20 > Simon, > do forget about my last mail.... Done :-)