From: Simon Horman <horms@verge.net.au>
To: Hans Schillstrom <hans.schillstrom@ericsson.com>
Cc: "lvs-devel@vger.kernel.org" <lvs-devel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>, "ja@ssi.bg" <ja@ssi.bg>,
"wensong@linux-vs.org" <wensong@linux-vs.org>,
"daniel.lezcano@free.fr" <daniel.lezcano@free.fr>
Subject: Re: [RFC PATCH 5/9] ipvs network name space aware
Date: Wed, 27 Oct 2010 06:03:22 +0900 [thread overview]
Message-ID: <20101026210321.GE13167@verge.net.au> (raw)
In-Reply-To: <201010261507.39734.hans.schillstrom@ericsson.com>
On Tue, Oct 26, 2010 at 03:07:38PM +0200, Hans Schillstrom wrote:
> On Friday 22 October 2010 21:05:48 Simon Horman wrote:
> > On Fri, Oct 08, 2010 at 01:17:02PM +0200, Hans Schillstrom wrote:
> > > This patch just contains ip_vs_ctl
> > >
> > > Signed-off-by:Hans Schillstrom <hans.schillstrom@ericsson.com>
> > >
> > > diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> > > index ca8ec8c..7e99cbc 100644
> > > --- a/net/netfilter/ipvs/ip_vs_ctl.c
> > > +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> >
> > [ snip ]
> > Hi Hans,
> >
> > is there a reason that the order some of the entries in
> > vs_vars has been switched around?
> >
> Yes there is, when vars will be copied to it's own NS it's a lot easier
> when they are in sequence and without a potential insert in the middle
> the #if 0 ...
>
> have a look at __ip_vs_control_init(struct net *net)
Ok, I suspected something like that.
In that case I think there may be a problem with
the way that I handled sysctl_ip_vs_conntrack.
prev parent reply other threads:[~2010-10-26 21:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 11:17 [RFC PATCH 5/9] ipvs network name space aware Hans Schillstrom
2010-10-20 15:21 ` Simon Horman
2010-10-21 7:35 ` Hans Schillstrom
2010-10-21 8:27 ` Horms
2010-10-21 11:16 ` Simon Horman
2010-10-21 11:26 ` Eric Dumazet
2010-10-21 11:49 ` Hans Schillstrom
2010-10-21 14:34 ` Simon Horman
2010-10-21 11:42 ` Hans Schillstrom
2010-10-21 22:56 ` Julian Anastasov
2010-10-22 19:05 ` Simon Horman
2010-10-26 13:07 ` Hans Schillstrom
2010-10-26 21:03 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026210321.GE13167@verge.net.au \
--to=horms@verge.net.au \
--cc=daniel.lezcano@free.fr \
--cc=hans.schillstrom@ericsson.com \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).