From: David Miller <davem@davemloft.net>
To: eparis@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
selinux@tycho.nsa.gov, netfilter-devel@vger.kernel.org,
equinox@diac24.net, eric.dumazet@gmail.com, hzhong@gmail.com,
jmorris@namei.org, kaber@trash.net, kuznet@ms2.inr.ac.ru,
paul.moore@hp.com, pekkas@netcore.fi, sds@tycho.nsa.gov,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH 2/3] network: tcp_connect should return certain errors up the stack
Date: Wed, 17 Nov 2010 10:56:00 -0800 (PST) [thread overview]
Message-ID: <20101117.105600.179937042.davem@davemloft.net> (raw)
In-Reply-To: <20101116215249.6727.89763.stgit@paris.rdu.redhat.com>
From: Eric Paris <eparis@redhat.com>
Date: Tue, 16 Nov 2010 16:52:49 -0500
> The current tcp_connect code completely ignores errors from sending an skb.
> This makes sense in many situations (like -ENOBUFFS) but I want to be able to
> immediately fail connections if they are denied by the SELinux netfilter hook.
> Netfilter does not normally return ECONNREFUSED when it drops a packet so we
> respect that error code as a final and fatal error that can not be recovered.
>
> Based-on-patch-by: Patrick McHardy <kaber@trash.net>
> Signed-off-by: Eric Paris <eparis@redhat.com>
Applied.
next prev parent reply other threads:[~2010-11-17 18:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 21:52 [PATCH 1/3] netfilter: allow hooks to pass error code back up the stack Eric Paris
2010-11-16 21:52 ` [PATCH 2/3] network: tcp_connect should return certain errors " Eric Paris
2010-11-17 18:56 ` David Miller [this message]
2010-11-16 21:52 ` [PATCH 3/3] SELinux: return -ECONNREFUSED from ip_postroute to signal fatal error Eric Paris
2010-11-17 11:43 ` Patrick McHardy
2010-11-17 14:38 ` Eric Paris
2010-11-17 18:55 ` David Miller
2010-11-17 18:56 ` David Miller
2010-11-19 15:11 ` Paul Moore
2010-11-17 18:55 ` [PATCH 1/3] netfilter: allow hooks to pass error code back up the stack David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117.105600.179937042.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=equinox@diac24.net \
--cc=eric.dumazet@gmail.com \
--cc=hzhong@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=pekkas@netcore.fi \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).