netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Holger Eitzenberger <holger@eitzenberger.org>
To: David Miller <davem@davemloft.net>
Cc: pablo@netfilter.org,
	netfilter-devel <netfilter-devel@vger.kernel.org>,
	netdev@vger.kernel.org
Subject: Re: ctnetlink loop
Date: Wed, 8 Dec 2010 21:31:21 +0100	[thread overview]
Message-ID: <20101208203121.GB23668@mail.eitzenberger.org> (raw)
In-Reply-To: <20101208.095020.245408999.davem@davemloft.net>

Hi,

> Holger, this replay -EAGAIN loop in nfnetlink processing was added by
> Pablo to handle module loading properly, I think.  So it might not be
> safe to just unilaterally remove it.

thanks for your reply!

Pablo, do we really need the replay loop really?  I now have several
boxes with problems due to this replay.  'perf report' always gives me
something like:

      18.88%            ulogd  [kernel]
  [k] __nla_put
      10.73%            ulogd  [kernel]
  [k] nla_parse
       8.72%            ulogd  [kernel]
  [k] __nla_reserve
       6.64%            ulogd  [kernel]
  [k] nla_put
       5.14%            ulogd  [kernel]
  [k] validate_nla
       5.03%            ulogd  [kernel]
  [k] pskb_expand_head
       4.92%            ulogd  [kernel]
  [k] ctnetlink_fill_info [nf_conntrack_netlink]
       3.07%            ulogd  [kernel]
  [k] skb_put
       3.03%            ulogd  [kernel]
  [k] ctnetlink_dump_counters [nf_conntrack

And 'strace' shows me that ulogd is stuck in its 'select' call.

 /holger

  reply	other threads:[~2010-12-08 20:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08 17:50 ctnetlink loop David Miller
2010-12-08 20:31 ` Holger Eitzenberger [this message]
2010-12-09 10:39   ` Pablo Neira Ayuso
     [not found] <20101203133903.GG13225@mail.eitzenberger.org>
2010-12-03 13:58 ` Holger Eitzenberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101208203121.GB23668@mail.eitzenberger.org \
    --to=holger@eitzenberger.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).