From: David Miller <davem@davemloft.net>
To: xiaosuo@gmail.com
Cc: kaber@trash.net, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] netfilter: don't need to initialize instance_table
Date: Thu, 09 Dec 2010 11:56:48 -0800 (PST) [thread overview]
Message-ID: <20101209.115648.104053657.davem@davemloft.net> (raw)
In-Reply-To: <1291889421-10794-1-git-send-email-xiaosuo@gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Thu, 9 Dec 2010 18:10:21 +0800
> Since instance_table is a static array, and has been zeroed already, we
> don't need to take CPU cycles to initialize it.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Adding a dependency on the implementation of HLISTs is not a good
idea, I would not apply this patch.
prev parent reply other threads:[~2010-12-09 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 10:10 [PATCH] netfilter: don't need to initialize instance_table Changli Gao
2010-12-09 14:03 ` Jan Engelhardt
2010-12-09 14:27 ` Changli Gao
2010-12-09 20:05 ` David Miller
2010-12-09 19:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209.115648.104053657.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).