From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH v3 net-next-2.6] netfilter: x_tables: dont block BH
 while reading counters
Date: Thu, 16 Dec 2010 12:12:38 -0800
Message-ID: <20101216121238.53deb370@nehalam>
References: <1292337974.9155.68.camel@firesoul.comx.local>
	<1292340702.5934.5.camel@edumazet-laptop>
	<1292342958.9155.91.camel@firesoul.comx.local>
	<1292343855.5934.27.camel@edumazet-laptop>
	<1292508266.31289.12.camel@firesoul.comx.local>
	<1292508733.2883.152.camel@edumazet-laptop>
	<1292509489.31289.20.camel@firesoul.comx.local>
	<1292509775.2883.187.camel@edumazet-laptop>
	<1292511761.2883.236.camel@edumazet-laptop>
	<1292515625.2883.336.camel@edumazet-laptop>
	<1292518436.2883.393.camel@edumazet-laptop>
	<20101216093149.71f082c7@nehalam>
	<1292521986.2883.472.camel@edumazet-laptop>
	<20101216095709.18f16c53@nehalam>
	<1292529519.2655.4.camel@edumazet-laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Jesper Dangaard Brouer <hawk@comx.dk>,
	Patrick McHardy <kaber@trash.net>,
	Arnaldo Carvalho de Melo <acme@infradead.org>,
	Steven Rostedt <srostedt@redhat.com>,
	Alexander Duyck <alexander.h.duyck@intel.com>,
	netfilter-devel <netfilter-devel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
In-Reply-To: <1292529519.2655.4.camel@edumazet-laptop>
Sender: netdev-owner@vger.kernel.org
List-Id: netfilter-devel.vger.kernel.org

On Thu, 16 Dec 2010 20:58:39 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> Le jeudi 16 d=E9cembre 2010 =E0 09:57 -0800, Stephen Hemminger a =E9c=
rit :
> > On Thu, 16 Dec 2010 18:53:06 +0100
> > Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >=20
> > > @@ -759,7 +742,7 @@ static struct xt_counters *alloc_counters(con=
st struct xt_table *table)
> > >  	 * about).
> > >  	 */
> > >  	countersize =3D sizeof(struct xt_counters) * private->number;
> > > -	counters =3D vmalloc(countersize);
> > > +	counters =3D vzalloc(countersize);
> > > =20
> > >  	if (counters =3D=3D NULL)
> > >  		return ERR_PTR(-ENOMEM);
> > > @@ -1007,7 +990,7 @@ static int __do_replace(struct net *net, con=
st char *name,
> > >  	struct arpt_entry *iter;
> > > =20
> > >  	ret =3D 0;
> > > -	counters =3D vmalloc(num_counters * sizeof(struct xt_counters))=
;
> > > +	counters =3D vzalloc(num_counters * sizeof(struct xt_counters))=
;
> > >  	if (!counters) {
> > >  		ret =3D -ENOMEM;
> > >  		goto out;
> >=20
> > This seems like a different and unrelated change.
> >=20
>=20
> Since you later Acked the patch, you probably know that we now provid=
e
> to get_counters() a zeroed area, since we do a sum for each possible
> cpu, I am answering anyway for other readers ;)
>=20
> Thanks for reviewing !

You changed from:
  get local cpu counters
  then sum other cpus
to:
  sum all cpu's.

This is fine, and will give the same answer.=20

--=20