From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: [PATCH 1/1] netfilter: ebtables: make broute table work again Date: Fri, 24 Dec 2010 01:55:50 +0100 Message-ID: <20101224005550.GA14050@strlen.de> References: <1293150436-12092-1-git-send-email-fw@strlen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org To: Changli Gao Return-path: Received: from Chamillionaire.breakpoint.cc ([85.10.199.196]:47596 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111Ab0LXBA2 (ORCPT ); Thu, 23 Dec 2010 20:00:28 -0500 Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Changli Gao wrote: > > diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c > > index 6f6d8e1..1d677bf 100644 > > --- a/net/bridge/br_input.c > > +++ b/net/bridge/br_input.c > > @@ -178,7 +178,7 @@ forward: > > =A0 =A0 =A0 =A0case BR_STATE_FORWARDING: > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0rhook =3D rcu_dereference(br_should_= route_hook); > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (rhook) { > > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if ((*rhook)(skb)) > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (rhook(skb)) >=20 > I don't think this change is necessary. Would you like to remove this > change and test again? Its not needed, but i consider it less confusing. I do not have a strong preference, though. -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html