From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: xiaosuo@gmail.com, kaber@trash.net,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] netfilter: fix the race when initializing nf_ct_expect_hash_rnd
Date: Wed, 05 Jan 2011 10:32:46 -0800 (PST) [thread overview]
Message-ID: <20110105.103246.193708786.davem@davemloft.net> (raw)
In-Reply-To: <1294250598.10633.77.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 05 Jan 2011 19:03:18 +0100
> Le mercredi 05 janvier 2011 à 22:23 +0800, Changli Gao a écrit :
>> Since nf_ct_expect_dst_hash() may be called without nf_conntrack_lock
>> locked, nf_ct_expect_hash_rnd should be initialized in the atomic way.
>>
>> In this patch, we use nf_conntrack_hash_rnd instead of
>> nf_ct_expect_hash_rnd.
>>
>> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
>> ---
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Problem is Patrick seems not responsive these days ;)
As a result, I'll integrate this fix later today.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-05 18:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 14:23 [PATCH v2] netfilter: fix the race when initializing nf_ct_expect_hash_rnd Changli Gao
2011-01-05 18:03 ` Eric Dumazet
2011-01-05 18:32 ` David Miller [this message]
2011-01-06 19:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105.103246.193708786.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).