From: Marek Kierdelewicz <marek@piasta.pl>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter@vger.kernel.org,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: new netfilter target - DNETMAP
Date: Sun, 9 Jan 2011 10:26:34 +0100 [thread overview]
Message-ID: <20110109102634.16b0a3c1@kuguar> (raw)
In-Reply-To: <alpine.LNX.2.01.1101070008590.19521@obet.zrqbmnf.qr>
Hi,
>It would be nice if you could
> * resolve the inconsistencies in indentation. Specifically, use tabs
> to indent statements. If in doubt, use scripts/Lindent
>and scripts/checkpatch.pl from linux.
Done. Patch passes checkpatch.pl except for:
- nf_conntrack_tuple.h and nf_nat.h in include/net/netfilter/;
these two files are copied frome kernel tree;
- lack of signed-off which AFAIK is used for kernel patches only;
I hope it's ok.
> * wrap lines at 80 cols in xt_DNETMAP.man
Done.
Updated versions are located here:
http://cat.piasta.pl/dnetmap/xtables-addons-1.31-dnetmap-1.0.tar.bz2
http://cat.piasta.pl/dnetmap/xtables-addons-1.31-dnetmap-1.0.patch.bz2
>Things I have noticed while spending a quick look:
>The manpage mentions "If host 192.168.0.10 generates some traffic, it
>gets bound to first free IP in subnet - 20.0.0.0.". However,
>20.0.0.0 can be a network address and thus lead to problems.
>Is there a way for the user to specify that the range to use
>should be 20.0.0.1-20.255.255.254 rather than 20.0.0.0-20.255.255.255?
To address your concerns I've added new module parameter:
whole_prefix: use network and broadcast addresses of specified prefix
for bindings (default: 1) (uint)
Implementing this as target parameter would be messy because data
structures for a given prefix are created on addition of the first
rule for a given prefix.
best regards,
Marek Kierdelewicz
prev parent reply other threads:[~2011-01-09 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110107000259.775ba310@kuguar>
2011-01-06 23:25 ` new netfilter target - DNETMAP Jan Engelhardt
2011-01-07 21:23 ` Marek Kierdelewicz
2011-01-09 9:26 ` Marek Kierdelewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110109102634.16b0a3c1@kuguar \
--to=marek@piasta.pl \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).