From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: GRO/GSO hiding PMTU?
Date: Thu, 10 Feb 2011 23:07:12 -0800 (PST) [thread overview]
Message-ID: <20110210.230712.183040908.davem@davemloft.net> (raw)
In-Reply-To: <20110211063753.GA29940@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 11 Feb 2011 17:37:53 +1100
> What I wanted to do if I ever get enough time to work on this is
> to record the transport header length in a gso_hlen field so we
> can fix this properly.
>
> We currently have a useless gso_segs field that only has one or
> two users that don't even need it. We could easily get rid of it
> and use that space for gso_hlen instead.
>
> The gso_hlen field only needs to be filled in at the few spots
> that generate GSO packets, i.e.,
>
> 1) TCP
> 2) Virt backends like tun.c
> 3) GRO
Yep, that's good idea.
And even if we needed to add one more u32 to skb_shared_info()
that's still sort-of "free" because of SLAB slack space.
I'll look into doing this.
Thanks!
prev parent reply other threads:[~2011-02-11 7:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 22:55 GRO/GSO hiding PMTU? David Miller
2011-02-10 23:07 ` David Miller
2011-02-11 0:07 ` Herbert Xu
2011-02-10 23:50 ` Herbert Xu
2011-02-11 6:22 ` David Miller
2011-02-11 6:35 ` David Miller
2011-02-11 6:41 ` Herbert Xu
2011-02-11 7:06 ` David Miller
2011-02-11 6:37 ` Herbert Xu
2011-02-11 7:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110210.230712.183040908.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).