From: Stephen Hemminger <shemminger@vyatta.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>,
David Miller <davem@davemloft.net>, Greg KH <greg@kroah.com>
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net, stable@kernel.org
Subject: Re: [PATCH] netfilter: ctnetlink: fix (really) race condition between dump_table and destroy
Date: Sun, 20 Feb 2011 12:48:14 -0800 [thread overview]
Message-ID: <20110220124814.2e89da91@nehalam> (raw)
In-Reply-To: <20110123231602.3383.31480.stgit@decadence>
On Mon, 24 Jan 2011 00:16:02 +0100
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> In 13ee6ac579574a2a95e982b19920fd2495dce8cd, we recovered spinlocks
> to protect the dump of the conntrack table according to reports from
> Stephen and acknowledgments on the issue from Eric.
>
> However, Stephen removed the refcount bump in that patch that allows
> to keep a reference to the current ct object we are interating over.
> That code avoids race conditions between ct object destruction and
> the iteration itself. This patch reintroduces these lines since the
> ct object may vanish between two recvmgs() invocations.
>
> This patch fixes ocasional crashes while dumping the conntrack table
> intensively.
>
> Cc: Stephen Hemminger <stephen.hemminger@vyatta.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
These two patches should have been submitted to the stable kernel.
next prev parent reply other threads:[~2011-02-20 20:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-23 23:16 [PATCH] netfilter: ctnetlink: fix (really) race condition between dump_table and destroy Pablo Neira Ayuso
2011-01-24 6:41 ` Eric Dumazet
2011-01-24 7:04 ` Eric Dumazet
2011-01-24 11:57 ` Pablo Neira Ayuso
2011-01-24 12:46 ` Patrick McHardy
2011-01-24 12:54 ` Eric Dumazet
2011-01-24 13:06 ` Pablo Neira Ayuso
2011-01-24 13:12 ` Eric Dumazet
2011-01-24 13:25 ` Pablo Neira Ayuso
2011-01-24 13:37 ` Patrick McHardy
2011-01-24 14:06 ` Eric Dumazet
2011-01-24 17:53 ` Patrick McHardy
2011-01-24 18:01 ` Eric Dumazet
2011-01-24 18:16 ` Patrick McHardy
2011-02-20 20:48 ` Stephen Hemminger [this message]
2011-02-20 20:51 ` [PATCH 1/2] netfilter: fix race in conntrack " Stephen Hemminger
2011-02-20 20:51 ` [PATCH 2/2] netfilter: ctnetlink: fix missing refcount increment during dumps Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110220124814.2e89da91@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).