From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch] fix nla_policy_len to actually _iterate_ over the policy Date: Mon, 28 Feb 2011 12:38:35 -0800 (PST) Message-ID: <20110228.123835.245399145.davem@davemloft.net> References: <20110228203559.GD8906@barkeeper1-xen.linbit> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, trivial@kernel.org, holger@eitzenberger.org, kaber@trash.net, netfilter-devel@vger.kernel.org, stable@kernel.org To: lars.ellenberg@linbit.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:56387 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667Ab1B1Uh6 (ORCPT ); Mon, 28 Feb 2011 15:37:58 -0500 In-Reply-To: <20110228203559.GD8906@barkeeper1-xen.linbit> Sender: netfilter-devel-owner@vger.kernel.org List-ID: From: Lars Ellenberg Date: Mon, 28 Feb 2011 21:35:59 +0100 > Currently nla_policy_len always returns n * NLA_HDRLEN: > It loops, but does not advance it's iterator. > NLA_UNSPEC == 0 does not contain a .len in any policy. > > Trivially fixed by adding p++. > > Signed-off-by: Lars Ellenberg Applied, thanks.