netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] netfilter: xt_addrtype: ipv6 support
Date: Sat, 19 Mar 2011 00:26:53 +0100	[thread overview]
Message-ID: <20110318232653.GC13371@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <4D80C12E.4010107@trash.net>

Patrick McHardy <kaber@trash.net> wrote:
> On 15.03.2011 19:49, Florian Westphal wrote:
[..]
> > +		rt = rt6_lookup(net, addr, NULL, ifindex, !!dev);
> 
> Florian, I just noticed that this will pull in the IPv6 module just
> by loading the xt_addrtype module. Can we convert this to use
> nf_ip6_afinfo->route() instead?

I tried this, but i found two issues:
- no netns support (nf_ip6_route passed init_net)
- its not possible to ask for RT6_LOOKUP_F_IFACE flag in the
  underlying fib6_rule_lookup() call.

But AFAICT the latter is needed to support the '--limit-iface-in/out'
option.

Any idea?

Otherwise I think I'll have a go at extending afinfo->route() to pass
in struct net* and a 'strict' argument (i.e. what rt6_lookup() has).

Unfortunately that would have to wait for 2.6.40...

Thanks,
Florian

  parent reply	other threads:[~2011-03-18 23:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-15 18:49 [PATCH v3 1/2] netfilter: ipt_addrtype: rename to xt_addrtype Florian Westphal
2011-03-15 18:49 ` [PATCH v3 2/2] netfilter: xt_addrtype: ipv6 support Florian Westphal
2011-03-15 19:41   ` Patrick McHardy
2011-03-16 13:54   ` Patrick McHardy
2011-03-16 14:19     ` Florian Westphal
2011-03-16 15:59       ` Florian Westphal
2011-03-16 16:03         ` Patrick McHardy
2011-03-18 23:26     ` Florian Westphal [this message]
2011-03-20 14:39       ` Patrick McHardy
2011-03-15 19:41 ` [PATCH v3 1/2] netfilter: ipt_addrtype: rename to xt_addrtype Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110318232653.GC13371@Chamillionaire.breakpoint.cc \
    --to=fw@strlen.de \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).