From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: fw@strlen.de, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/3] netfilter: af_info: add 'strict' parameter to limit lookup to .oif
Date: Mon, 21 Mar 2011 16:58:29 -0700 (PDT) [thread overview]
Message-ID: <20110321.165829.28821319.davem@davemloft.net> (raw)
In-Reply-To: <1300747379.2837.23.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 21 Mar 2011 23:42:59 +0100
> Ah sorry, I missed the "static const". Maybe I should just sleep now ;)
Well, I would really prefer if ip6_route_output() and friends mark
their 'sk' argument as 'const'.
Otherwise someone is going to read this code and be really concerned
that "sk" really might be modified in some way by this code path,
thus making parallel access to this static const 'sk' illegal.
next prev parent reply other threads:[~2011-03-21 23:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 22:25 [PATCH 1/3] netfilter: af_info: add network namespace parameter to route hook Florian Westphal
2011-03-21 22:25 ` [PATCH 2/3] netfilter: af_info: add 'strict' parameter to limit lookup to .oif Florian Westphal
2011-03-21 22:39 ` Eric Dumazet
2011-03-21 22:42 ` Eric Dumazet
2011-03-21 23:58 ` David Miller [this message]
2011-03-22 21:26 ` Florian Westphal
2011-03-22 21:42 ` David Miller
2011-03-21 22:25 ` [PATCH 3/3] netfilter: xt_addrtype: replace rt6_lookup with nf_afinfo->route Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110321.165829.28821319.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).