From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net
Subject: [PATCH 0/2] rework of userspace expectation support
Date: Tue, 12 Apr 2011 23:59:12 +0200 [thread overview]
Message-ID: <20110412215458.3145.40830.stgit@decadence> (raw)
Hi Patrick,
The following patches rework the userspace expectation support
to fix one problematic scenario: if the master conntrack vanishes
while there are still userspace expectations, we hit an oops
in the destroy event path for expectations.
The idea to fix this is to extend the iptables CT target to
explicit allocate the helper extension for conntracks that
are suppose to behave as master for user-space expectations.
In the case of the userspace FTP helper, people would need
to add the following rule:
iptables -A PREROUTING -t raw \
-p tcp --dport 21 -j CT --userspace-helper
Thus, we can store the list of expectations that belong to
one master, and delete them in case that the master vanishes.
---
Pablo Neira Ayuso (2):
netfilter: CT: allow to set userspace helper status flag
netfilter: nf_ct_expect: rework userspace expectation support
include/linux/netfilter/nf_conntrack_common.h | 4 ++
include/linux/netfilter/xt_CT.h | 3 +
include/net/netfilter/nf_conntrack_expect.h | 1
net/netfilter/nf_conntrack_expect.c | 63 ++++++++-----------------
net/netfilter/nf_conntrack_helper.c | 12 +++++
net/netfilter/nf_conntrack_netlink.c | 5 ++
net/netfilter/xt_CT.c | 8 ++-
7 files changed, 48 insertions(+), 48 deletions(-)
next reply other threads:[~2011-04-12 21:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 21:59 Pablo Neira Ayuso [this message]
2011-04-12 21:59 ` [PATCH 1/2] netfilter: CT: allow to set userspace helper status flag Pablo Neira Ayuso
2011-04-12 21:59 ` [PATCH 2/2] netfilter: nf_ct_expect: rework userspace expectation support Pablo Neira Ayuso
2011-04-13 11:37 ` [PATCH 0/2] rework of " Patrick McHardy
2011-04-13 11:47 ` Pablo Neira Ayuso
2011-04-13 11:55 ` Patrick McHardy
2011-04-13 12:11 ` Pablo Neira Ayuso
2011-04-13 12:28 ` Patrick McHardy
2011-04-13 20:02 ` Pablo Neira Ayuso
2011-04-20 12:10 ` Pablo Neira Ayuso
2011-04-20 14:06 ` Patrick McHardy
2011-04-21 13:14 ` Pablo Neira Ayuso
2011-05-17 21:12 ` Sam Roberts
2011-06-13 21:57 ` Sam Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412215458.3145.40830.stgit@decadence \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).