From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [stable] [PATCH 1/2] netfilter: IPv6: initialize TOS field in REJECT target module Date: Mon, 6 Jun 2011 10:36:23 -0700 Message-ID: <20110606173623.GC7394@kroah.com> References: <1307320871-31770-1-git-send-email-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: stable@kernel.org, Fernando Luis Vazquez Cao , netfilter-devel@vger.kernel.org To: pablo@netfilter.org Return-path: Received: from out3.smtp.messagingengine.com ([66.111.4.27]:38772 "EHLO out3.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752301Ab1FFRhD (ORCPT ); Mon, 6 Jun 2011 13:37:03 -0400 Content-Disposition: inline In-Reply-To: <1307320871-31770-1-git-send-email-pablo@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Mon, Jun 06, 2011 at 02:41:10AM +0200, pablo@netfilter.org wrote: > From: Fernando Luis Vazquez Cao > > The IPv6 header is not zeroed out in alloc_skb so we must initialize > it properly unless we want to see IPv6 packets with random TOS fields > floating around. The current implementation resets the flow label > but this could be changed if deemed necessary. > > We stumbled upon this issue when trying to apply a mangle rule to > the RST packet generated by the REJECT target module. > > The following Linux kernels are affected: <= 2.6.38.8 > > Cc: stable@kernel.org > Signed-off-by: Fernando Luis Vazquez Cao > Signed-off-by: Pablo Neira Ayuso > (cherry picked from commit 4319cc0cf5bb894b7368008cdf6dd20eb8868018) So, what kernel(s) are you wanting this to be applied to? Should I just take the upstream 4319cc0cf5bb894b7368008cdf6dd20eb8868018, or does your backport do something different here? Same goes for the 2/2 patch, please be more specific. thanks, greg k-h