From: David Miller <davem@davemloft.net>
To: sebastian@breakpoint.cc
Cc: kaber@trash.net, netfilter-devel@vger.kernel.org,
netfilter@vger.kernel.org, coreteam@netfilter.org,
tglx@linutronix.de
Subject: Re: [RFC] SLOB breaks netfilter
Date: Tue, 07 Jun 2011 14:18:10 -0700 (PDT) [thread overview]
Message-ID: <20110607.141810.2159514423065256050.davem@davemloft.net> (raw)
In-Reply-To: <20110607210651.GA11159@Chamillionaire.breakpoint.cc>
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Date: Tue, 7 Jun 2011 23:06:51 +0200
> and SLOB defines:
>
> |#ifdef ARCH_DMA_MINALIGN
> |#define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN
> |#else
> |#define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long)
> |#endif
SLOB should really use "unsigned long long" I think.
An allocator needs to provide memory with the maximum
alignment that might be required for types on a given
architecture.
next prev parent reply other threads:[~2011-06-07 21:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 21:06 [RFC] SLOB breaks netfilter Sebastian Andrzej Siewior
2011-06-07 21:18 ` David Miller [this message]
2011-06-08 7:10 ` Sebastian Siewior
2011-06-07 21:27 ` Jan Engelhardt
2011-06-07 21:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607.141810.2159514423065256050.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=coreteam@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=sebastian@breakpoint.cc \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).