From: David Miller <davem@davemloft.net>
To: jj@chaosbits.net
Cc: netdev@vger.kernel.org, coreteam@netfilter.org,
netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, xeb@mail.ru
Subject: Re: [PATCH] Remove redundant linux/version.h includes from net/
Date: Tue, 21 Jun 2011 16:03:34 -0700 (PDT) [thread overview]
Message-ID: <20110621.160334.1438754754048406782.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1106210009520.27735@swampdragon.chaosbits.net>
From: Jesper Juhl <jj@chaosbits.net>
Date: Tue, 21 Jun 2011 00:13:10 +0200 (CEST)
> It was suggested by "make versioncheck" that the follwing includes of
> linux/version.h are redundant:
>
> /home/jj/src/linux-2.6/net/caif/caif_dev.c: 14 linux/version.h not needed.
> /home/jj/src/linux-2.6/net/caif/chnl_net.c: 10 linux/version.h not needed.
> /home/jj/src/linux-2.6/net/ipv4/gre.c: 19 linux/version.h not needed.
> /home/jj/src/linux-2.6/net/netfilter/ipset/ip_set_core.c: 20 linux/version.h not needed.
> /home/jj/src/linux-2.6/net/netfilter/xt_set.c: 16 linux/version.h not needed.
>
> and it seems that it is right.
>
> Beyond manually inspecting the source files I also did a few build
> tests with various configs to confirm that including the header in
> those files is indeed not needed.
>
> Here's a patch to remove the pointless includes.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Applied, thanks.
prev parent reply other threads:[~2011-06-21 23:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 22:13 [PATCH] Remove redundant linux/version.h includes from net/ Jesper Juhl
2011-06-21 6:58 ` [netfilter-core] " Jozsef Kadlecsik
2011-06-21 23:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110621.160334.1438754754048406782.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=coreteam@netfilter.org \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=xeb@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).