From: Florian Westphal <fw@strlen.de>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Patrick McHardy <kaber@trash.net>,
hawk@diku.dk,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] netfilter: better wording for table-full message
Date: Tue, 23 Aug 2011 15:25:03 +0200 [thread overview]
Message-ID: <20110823132503.GE25003@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <alpine.LNX.2.01.1108231507040.24849@frira.zrqbmnf.qr>
Jan Engelhardt <jengelh@medozas.de> wrote:
> parent ad146381889371c2d1b89b27d9dc70ae257fc1c8 (v3.1-rc2-2-gad14638)
> commit 51b33b93d4c2e6c63afb177158f660fd17daf47c
> Author: Jan Engelhardt <jengelh@medozas.de>
> Date: Tue Aug 23 15:07:00 2011 +0200
>
> netfilter: better wording for table-full message
> - "nf_conntrack: table full, dropping"
> - " packet.\n");
> + "nf_conntrack: table full, no new "
> + "CT created, packet will have "
> + "classification INVALID.\n");
packets seem to be dropped after all; call chain is:
nf_conntrack_in -> resolve_normal_ct -> init_conntrack -> __nf_conntrack_alloc.
AFAICS, the -ENOMEM is propagated back to nf_conntrack_in, where ret
will be set to NF_DROP.
The important point is resolve_normal_ct() return value;
on NULL the packet would be untracked.
next prev parent reply other threads:[~2011-08-23 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 13:07 [PATCH] netfilter: better wording for table-full message Jan Engelhardt
2011-08-23 13:25 ` Florian Westphal [this message]
2011-08-23 16:19 ` Stephen Clark
2011-08-24 7:28 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823132503.GE25003@Chamillionaire.breakpoint.cc \
--to=fw@strlen.de \
--cc=hawk@diku.dk \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).