From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Anthony G. Basile" <basile@opensource.dyc.edu>
Cc: davem@davemloft.net, kaber@trash.net, blueness@gentoo.org,
gurligebis@gentoo.org, base-system@gentoo.org, kernel@gentoo.org,
toolchain@gentoo.org, mchehab@redhat.com, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com, arnd@arndb.de,
eparis@redhat.com, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: install nf_nat.h and nf_conntrack_tuple.h to INSTALL_HDR_PATH
Date: Mon, 12 Sep 2011 11:19:13 +0200 [thread overview]
Message-ID: <20110912091913.GA2194@1984> (raw)
In-Reply-To: <20110912083839.GA2017@1984>
On Mon, Sep 12, 2011 at 10:38:39AM +0200, Pablo Neira Ayuso wrote:
> > +/* Single range specification. */
> > +struct nf_nat_range {
> > + /* Set to OR of flags above. */
> > + unsigned int flags;
> > +
> > + /* Inclusive: network order. */
> > + __be32 min_ip, max_ip;
> > +
> > + /* Inclusive: network order */
> > + union nf_conntrack_man_proto min, max;
>
> Better replace union nf_conntrack_man_proto by __be16, we don't break
> binary compatibility and we don't need to export the whole tuple
> definitions.
Hm, I just noticed that this will not work that easy.
git grep shows several NAT protocol helpers that rely on
nf_conntrack_man_proto under net/ipv4/netfilter/, we need to change
those as well to use the new definition of nf_nat_range.
I think I prefer the change that I'm proposing that exporting the
whole nf_conntrack_tuple.h header file.
next prev parent reply other threads:[~2011-09-12 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 0:16 [PATCH] netfilter: install nf_nat.h and nf_conntrack_tuple.h to INSTALL_HDR_PATH Anthony G. Basile
2011-09-12 8:38 ` Pablo Neira Ayuso
2011-09-12 9:19 ` Pablo Neira Ayuso [this message]
2011-09-20 15:33 ` Anthony G. Basile
2011-09-28 21:37 ` Pablo Neira Ayuso
2011-09-29 21:03 ` Anthony G. Basile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110912091913.GA2194@1984 \
--to=pablo@netfilter.org \
--cc=arnd@arndb.de \
--cc=base-system@gentoo.org \
--cc=basile@opensource.dyc.edu \
--cc=blueness@gentoo.org \
--cc=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=gurligebis@gentoo.org \
--cc=hverkuil@xs4all.nl \
--cc=kaber@trash.net \
--cc=kernel@gentoo.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=mchehab@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=toolchain@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).