From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Alex Bligh <alex@alex.org.uk>,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org,
Linux Containers <containers@lists.osdl.org>
Subject: Re: [PATCH] Fix repeatable Oops on container destroy with conntrack
Date: Mon, 12 Sep 2011 11:37:49 +0200 [thread overview]
Message-ID: <20110912093749.GE2194@1984> (raw)
In-Reply-To: <20110912072524.GA2996@p183.telecom.by>
On Mon, Sep 12, 2011 at 10:25:24AM +0300, Alexey Dobriyan wrote:
> On Sat, Sep 10, 2011 at 07:48:43PM +0100, Alex Bligh wrote:
> > --- a/net/netfilter/nf_conntrack_netlink.c
> > +++ b/net/netfilter/nf_conntrack_netlink.c
> > @@ -570,6 +570,11 @@ ctnetlink_conntrack_event(unsigned int events, struct nf_ct_event *item)
> > return 0;
> >
> > net = nf_ct_net(ct);
> > +
> > + /* container deinit, netlink may have died before death_by_timeout */
> > + if (!net->nfnl)
> > + return 0;
> > +
> > if (!item->report && !nfnetlink_has_listeners(net, group))
> > return 0;
>
> If this is correct fix, ->nfnl check should be folded into
> nfnetlink_has_listeners(), otherwise expectations aren't covered.
Agreed.
next prev parent reply other threads:[~2011-09-12 9:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-10 18:48 [PATCH] Fix repeatable Oops on container destroy with conntrack Alex Bligh
2011-09-12 7:25 ` Alexey Dobriyan
2011-09-12 9:37 ` Pablo Neira Ayuso [this message]
2011-09-12 10:32 ` Alex Bligh
2011-09-12 18:33 ` Pablo Neira Ayuso
2011-09-12 19:06 ` Alex Bligh
2011-09-13 20:44 ` Alex Bligh
2011-09-14 1:35 ` Pablo Neira Ayuso
2011-09-14 8:01 ` Alex Bligh
2011-09-28 21:08 ` Pablo Neira Ayuso
2011-09-30 15:54 ` Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110912093749.GE2194@1984 \
--to=pablo@netfilter.org \
--cc=adobriyan@gmail.com \
--cc=alex@alex.org.uk \
--cc=containers@lists.linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=coreteam@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).