From: Hans Schillstrom <hans@schillstrom.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: Hans Schillstrom <hans.schillstrom@ericsson.com>,
horms@verge.net.au, wensong@linux-vs.org,
lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] IPVS netns shutdown/startup dead-lock (Take II)
Date: Mon, 3 Oct 2011 23:12:13 +0200 [thread overview]
Message-ID: <201110032312.13966.hans@schillstrom.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1110032350500.1868@ja.ssi.bg>
Hi Julian
On Monday, October 03, 2011 22:55:02 Julian Anastasov wrote:
>
> Hello,
>
> On Mon, 3 Oct 2011, Hans Schillstrom wrote:
>
> > From: Hans Schillstrom <hans@schillstrom.com>
> >
> > ip_vs_mutext is used by both netns shutdown code and startup
> > and both implicit uses sk_lock-AF_INET mutex.
> >
> > cleanup CPU-1 startup CPU-2
> > ip_vs_dst_event() ip_vs_genl_set_cmd()
> > sk_lock-AF_INET __ip_vs_mutex
> > sk_lock-AF_INET
> > __ip_vs_mutex
> > * DEAD LOCK *
> >
> > A new mutex placed in ip_vs netns struct called sync_mutex is added.
> >
> > Comments from Julian and Simon added.
> > This patch has been running for more than 3 month now and it seems to work.
>
> May be IP_VS_SO_GET_DAEMON in do_ip_vs_get_ctl
> must be protected by sync_mutex in a similar way.
>
That's right there is a small risk inconsistent data there...
I will send a new patch tomorrow.
Thanks
Hans
next prev parent reply other threads:[~2011-10-03 21:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 10:56 [PATCH 1/2] fix lockdep warning Hans Schillstrom
2011-10-03 10:56 ` [PATCH 2/2] IPVS netns shutdown/startup dead-lock (Take II) Hans Schillstrom
2011-10-03 20:55 ` Julian Anastasov
2011-10-03 21:12 ` Hans Schillstrom [this message]
2011-10-04 21:14 ` [PATCH 1/2] fix lockdep warning Simon Horman
2011-10-04 22:51 ` Julian Anastasov
2011-10-05 6:31 ` Hans Schillstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110032312.13966.hans@schillstrom.com \
--to=hans@schillstrom.com \
--cc=hans.schillstrom@ericsson.com \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).