From: David Miller <davem@davemloft.net>
To: hidden@balabit.hu
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] tproxy: copy transparent flag when creating a time wait
Date: Tue, 18 Oct 2011 16:48:03 -0400 (EDT) [thread overview]
Message-ID: <20111018.164803.588126048510438075.davem@davemloft.net> (raw)
In-Reply-To: <1318969055.2959.7.camel@nessa.odu>
From: KOVACS Krisztian <hidden@balabit.hu>
Date: Tue, 18 Oct 2011 22:17:35 +0200
> The transparent socket option setting was not copied to the time wait
> socket when an inet socket was being replaced by a time wait socket. This
> broke the --transparent option of the socket match and may have caused
> that FIN packets belonging to sockets in FIN_WAIT2 or TIME_WAIT state
> were being dropped by the packet filter.
>
> Signed-off-by: KOVACS Krisztian <hidden@balabit.hu>
I can't believe such a fundamental bug went unspotted for so long :-)
I'll apply this, thanks.
prev parent reply other threads:[~2011-10-18 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 20:17 [PATCH] tproxy: copy transparent flag when creating a time wait KOVACS Krisztian
2011-10-18 20:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111018.164803.588126048510438075.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hidden@balabit.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).