From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH][RESEND] netfilter: ipv6: fix afinfo->route refcnt leak on error
Date: Thu, 20 Oct 2011 12:28:46 +0200 [thread overview]
Message-ID: <20111020102846.GA20625@1984> (raw)
In-Reply-To: <20111019112305.GC10691@Chamillionaire.breakpoint.cc>
On Wed, Oct 19, 2011 at 01:23:06PM +0200, Florian Westphal wrote:
> Several callers (h323 conntrack, xt_addrtype) assume that the
> returned **dst only needs to be released if the function returns 0.
>
> This is true for the ipv4 implementation, but not for the ipv6 one.
>
> Instead of changing the users, change the ipv6 implementation
> to behave like the ipv4 version by only providing the dst_entry result
> in the success case.
Indeed, we're leaking refcounts of template routes defined in
net/ipv6/route.c
I have applied this patch to my nf branch:
http://1984.lsi.us.es/git/?p=net/.git;a=shortlog;h=refs/heads/nf
Thanks Florian.
prev parent reply other threads:[~2011-10-20 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 11:23 [PATCH][RESEND] netfilter: ipv6: fix afinfo->route refcnt leak on error Florian Westphal
2011-10-20 10:28 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111020102846.GA20625@1984 \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).