From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alex Bligh <alex@alex.org.uk>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
kaber@trash.net, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: fix ->nfnl NULL oops
Date: Tue, 22 Nov 2011 00:39:42 +0100 [thread overview]
Message-ID: <20111121233942.GA13815@1984> (raw)
In-Reply-To: <61996646E807F2E67842E57F@nimrod.local>
Hi Alex,
On Tue, Nov 15, 2011 at 10:13:58AM +0000, Alex Bligh wrote:
> Pablo,
>
> Have you tried this patch (without the ->nfnl NULL check change) with
> the perl program I wrote that reliably replicates the original bug?
>
> https://bugs.launchpad.net/ubuntu/+source/linux-lts-backport-natty/+bug/843892
>
> specifically the attachment in comment #6:
>
> https://bugs.launchpad.net/ubuntu/+source/linux-lts-backport-natty/+bug/843892/+attachment/2382526/+files/testns.pl
I didn't try with this script, but the problem can be easily
triggered with:
0) make sure nf_conntrack_netlink and nf_conntrack_ipv4 are loaded.
1) container is started.
2) connect to it via lxc-console.
3) generate some traffic with the container to create some conntrack
entries in its table.
4) stop the container: hit the oops.
I've been testing the patch that I proposed with this recipe, now it
works fine.
I'll pass my patch for 3.2-rc soon, in case you want to make further
testing of it.
next prev parent reply other threads:[~2011-11-21 23:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 22:16 [PATCH] netfilter: fix ->nfnl NULL oops Alexey Dobriyan
2011-11-08 22:50 ` Alex Bligh
2011-11-09 14:35 ` Pablo Neira Ayuso
2011-11-09 19:04 ` Alex Bligh
2011-11-09 14:34 ` Pablo Neira Ayuso
2011-11-09 19:06 ` Alex Bligh
2011-11-15 9:56 ` Pablo Neira Ayuso
2011-11-15 10:13 ` Alex Bligh
2011-11-15 14:09 ` Pablo Neira Ayuso
2011-11-21 23:39 ` Pablo Neira Ayuso [this message]
2011-11-21 23:42 ` Pablo Neira Ayuso
2011-11-21 23:50 ` Alex Bligh
2011-11-22 14:23 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121233942.GA13815@1984 \
--to=pablo@netfilter.org \
--cc=adobriyan@gmail.com \
--cc=alex@alex.org.uk \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).