From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] libxt_connbytes: fix handling of --connbytes FROM
Date: Fri, 23 Dec 2011 14:57:32 +0100 [thread overview]
Message-ID: <20111223135731.GB10482@1984> (raw)
In-Reply-To: <1324056846-557-1-git-send-email-fw@strlen.de>
On Fri, Dec 16, 2011 at 06:34:06PM +0100, Florian Westphal wrote:
> quoting man page:
>
> match packets from a connection whose packets/bytes/average
> packet size is more than FROM and less than TO bytes/packets. if
> TO is omitted only FROM check is done.
>
> But, when TO was omitted, we did treat it like "x:x" which is not
> the same at all.
>
> Before commit 09631dc60ce41bc484a42fcf4d4ddf7036820bd1
> (libxt_connbytes: use guided option parser), we failed to parse
> "--connbytes x" ('Bad range "x"'), but treated "x:" like "x:0xffffffff".
>
> Also, restore the "from must be smaller than to" check.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied, thanks!
prev parent reply other threads:[~2011-12-23 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 17:34 [PATCH] libxt_connbytes: fix handling of --connbytes FROM Florian Westphal
2011-12-23 13:57 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111223135731.GB10482@1984 \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).