From: Pablo Neira Ayuso <pablo@netfilter.org>
To: David Miller <davem@davemloft.net>
Cc: rdunlap@xenotime.net, sfr@canb.auug.org.au,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: linux-next: Tree for Dec 28 (nfnetlink)
Date: Thu, 29 Dec 2011 02:03:30 +0100 [thread overview]
Message-ID: <20111229010330.GA2663@1984> (raw)
In-Reply-To: <20111228.153304.1267926241298522965.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
On Wed, Dec 28, 2011 at 03:33:04PM -0500, David Miller wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> Date: Wed, 28 Dec 2011 13:19:08 -0800
>
> > On 12/28/2011 01:18 AM, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> I got bored :-( I also hate tree wide, flag day changes :-(
> >>
> >> Changes since 20111222:
> >
> >
> >
> > warning: (NETFILTER_XT_MATCH_NFACCT) selects NETFILTER_NETLINK_ACCT which has unmet direct dependencies (NET && INET && NETFILTER && NETFILTER_ADVANCED)
> >
> > and then
> >
> > ERROR: "nfnetlink_subsys_unregister" [net/netfilter/nfnetlink_acct.ko] undefined!
> > ERROR: "nfnetlink_subsys_register" [net/netfilter/nfnetlink_acct.ko] undefined!
> >
> >
> > Full randconfig file is attached.
>
> Pablo please fix this, thanks.
Please, apply the following patch.
[-- Attachment #2: 0001-netfilter-Kconfig-fix-unmet-xt_nfacct-dependencies.patch --]
[-- Type: text/x-diff, Size: 1204 bytes --]
>From 3e52c20b633f9c829eaa9fe693a0cbef10ac4d02 Mon Sep 17 00:00:00 2001
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Thu, 29 Dec 2011 01:50:25 +0100
Subject: [PATCH] netfilter: Kconfig: fix unmet xt_nfacct dependencies
warning: (NETFILTER_XT_MATCH_NFACCT) selects NETFILTER_NETLINK_ACCT which has
nmet direct dependencies (NET && INET && NETFILTER && NETFILTER_ADVANCED)
and then
ERROR: "nfnetlink_subsys_unregister" [net/netfilter/nfnetlink_acct.ko]
ndefined!
ERROR: "nfnetlink_subsys_register" [net/netfilter/nfnetlink_acct.ko]
+undefined!
Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/netfilter/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index f6275a0..f8ac4ef 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -908,7 +908,7 @@ config NETFILTER_XT_MATCH_MULTIPORT
config NETFILTER_XT_MATCH_NFACCT
tristate '"nfacct" match support'
- default m if NETFILTER_ADVANCED=n
+ depends on NETFILTER_ADVANCED
select NETFILTER_NETLINK_ACCT
help
This option allows you to use the extended accounting through
--
1.7.7.3
next prev parent reply other threads:[~2011-12-29 1:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111228201806.d6de27fa2dbd9e3a3b7a2603@canb.auug.org.au>
2011-12-28 21:19 ` linux-next: Tree for Dec 28 (nfnetlink) Randy Dunlap
2011-12-28 20:33 ` David Miller
2011-12-29 1:03 ` Pablo Neira Ayuso [this message]
2011-12-29 18:53 ` Randy Dunlap
2011-12-29 19:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111229010330.GA2663@1984 \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).