From: Hagen Paul Pfeifer <hagen@jauu.net>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Ben Hutchings <bhutchings@solarflare.com>,
netdev <netdev@vger.kernel.org>,
netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [RFC] netem: de-GSO packets before enqueing
Date: Sat, 14 Jan 2012 17:06:46 +0100 [thread overview]
Message-ID: <20120114160646.GB2966@hell> (raw)
In-Reply-To: <20120112165720.4545c670@nehalam.linuxnetplumber.net>
* Stephen Hemminger | 2012-01-12 16:57:20 [-0800]:
>Probably something like this is needed (untested).
>
>This issue was discovered when looking at the skb_checksum path for the
>netem corruption operation, but it is a general problem.
>Network emulation operations like corruption and drop want to operate
>on a per-packet (not per-segment) basis. This patch does GSO in software
>if necessary to break up packets. Code is similar to logic in xfrm_output.
>
>Although it appears that the operation is not work conserving, it is okay
>because the higher level qdisc operations account for packets by incrementing
>by gso_size.
Thanks Stephen! Corruption is currently unusable if GSO is enabled. We disable
GSO/TSO on all our test machines therefore.
I have a larger set of patches for the corruption option for this merge
window. We will now test your patch (and the hopefully following qdisc len
updated patch).
Hagen
next prev parent reply other threads:[~2012-01-14 16:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 20:42 skb_checksum_help() vs GSO Ben Hutchings
2012-01-12 22:03 ` Herbert Xu
2012-01-13 0:57 ` [RFC] netem: de-GSO packets before enqueing Stephen Hemminger
2012-01-13 15:54 ` Eric Dumazet
2012-01-13 19:20 ` Stephen Hemminger
2012-01-13 23:44 ` Eric Dumazet
2012-01-14 16:06 ` Hagen Paul Pfeifer [this message]
2012-01-12 22:10 ` skb_checksum_help() vs GSO Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120114160646.GB2966@hell \
--to=hagen@jauu.net \
--cc=bhutchings@solarflare.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).