From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/1] netfilter: nf_queue: fix queueing of bridged gro skbs
Date: Thu, 9 Feb 2012 16:44:21 +0100 [thread overview]
Message-ID: <20120209154421.GA5865@1984> (raw)
In-Reply-To: <1328530990-6782-1-git-send-email-fw@strlen.de>
Hi Florian,
On Mon, Feb 06, 2012 at 01:23:10PM +0100, Florian Westphal wrote:
> When trying to nf_queue GRO/GSO skbs, nf_queue uses skb_gso_segment
> to split the skb.
>
> However, if nf_queue is called via bridge netfilter, the mac header
> won't be preserved -- packets will thus contain a bogus mac header.
>
> Fix this by setting skb->data to the mac header when skb->nf_bridge
> is set and restoring skb->data afterwards for all segments.
Better fix skb_gso_segment to handle this case?
next prev parent reply other threads:[~2012-02-09 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 12:23 [PATCH 1/1] netfilter: nf_queue: fix queueing of bridged gro skbs Florian Westphal
2012-02-09 15:44 ` Pablo Neira Ayuso [this message]
2012-02-09 16:37 ` Florian Westphal
2012-02-09 18:44 ` David Miller
2012-02-09 19:37 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209154421.GA5865@1984 \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).