From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
netfilter-devel@vger.kernel.org,
Zambo Marcell <marcell.zambo@gmail.com>
Subject: Re: [PATCH 1/1] netfilter: fix soft lockup when netlink adds new entries
Date: Fri, 24 Feb 2012 12:36:13 +0100 [thread overview]
Message-ID: <20120224113613.GA9730@1984> (raw)
In-Reply-To: <20120224100121.GB9127@1984>
On Fri, Feb 24, 2012 at 11:01:21AM +0100, Pablo Neira Ayuso wrote:
> On Fri, Feb 24, 2012 at 07:44:23AM +0100, Eric Dumazet wrote:
> > Le vendredi 24 février 2012 à 02:24 +0100, Pablo Neira Ayuso a écrit :
> >
> > > BTW, nf_conntrack_alloc allocation can now be GFP_KERNEL.
> > >
> >
> > Without looking at the code, I would say I doubt its doable ;)
> >
> > Input path is run from softirq handler.
>
> This is ctnetlink, conntracks are always created from user context :)
I noticed we're holding rcu read side so we cannot switch to
GFP_KERNEL, you were right (for different reason though ;-).
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-02-24 11:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 13:53 [PATCH 0/1] netfilter: fix soft lockup when netlink adds new entries Jozsef Kadlecsik
2012-02-21 13:53 ` [PATCH 1/1] " Jozsef Kadlecsik
2012-02-21 14:52 ` Pablo Neira Ayuso
2012-02-21 15:06 ` Jozsef Kadlecsik
2012-02-21 15:20 ` Pablo Neira Ayuso
2012-02-23 10:12 ` Pablo Neira Ayuso
2012-02-23 12:43 ` Jozsef Kadlecsik
2012-02-23 15:46 ` Pablo Neira Ayuso
2012-02-23 20:44 ` Jozsef Kadlecsik
2012-02-24 1:24 ` Pablo Neira Ayuso
2012-02-24 6:44 ` Eric Dumazet
2012-02-24 10:01 ` Pablo Neira Ayuso
2012-02-24 10:11 ` Jozsef Kadlecsik
2012-02-24 11:36 ` Pablo Neira Ayuso [this message]
2012-02-24 8:06 ` Jozsef Kadlecsik
2012-02-24 9:59 ` Pablo Neira Ayuso
2012-02-24 10:09 ` Jozsef Kadlecsik
2012-02-24 10:45 ` Jozsef Kadlecsik
2012-02-24 11:18 ` Pablo Neira Ayuso
2012-02-24 11:33 ` Pablo Neira Ayuso
2012-02-24 17:05 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120224113613.GA9730@1984 \
--to=pablo@netfilter.org \
--cc=eric.dumazet@gmail.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=marcell.zambo@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).