From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH 1/1] netfilter: fix soft lockup when netlink adds new entries Date: Fri, 24 Feb 2012 12:36:13 +0100 Message-ID: <20120224113613.GA9730@1984> References: <1329832437-8733-2-git-send-email-kadlec@blackhole.kfki.hu> <20120221145234.GB25826@1984> <20120223101250.GA3547@1984> <20120223154646.GA4790@1984> <20120224012449.GA7005@1984> <1330065863.15610.46.camel@edumazet-laptop> <20120224100121.GB9127@1984> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jozsef Kadlecsik , netfilter-devel@vger.kernel.org, Zambo Marcell To: Eric Dumazet Return-path: Received: from mail.us.es ([193.147.175.20]:42447 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290Ab2BXLge (ORCPT ); Fri, 24 Feb 2012 06:36:34 -0500 Content-Disposition: inline In-Reply-To: <20120224100121.GB9127@1984> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Fri, Feb 24, 2012 at 11:01:21AM +0100, Pablo Neira Ayuso wrote: > On Fri, Feb 24, 2012 at 07:44:23AM +0100, Eric Dumazet wrote: > > Le vendredi 24 f=E9vrier 2012 =E0 02:24 +0100, Pablo Neira Ayuso a = =E9crit : > >=20 > > > BTW, nf_conntrack_alloc allocation can now be GFP_KERNEL. > > >=20 > >=20 > > Without looking at the code, I would say I doubt its doable ;) > > > > Input path is run from softirq handler. >=20 > This is ctnetlink, conntracks are always created from user context :) I noticed we're holding rcu read side so we cannot switch to GFP_KERNEL, you were right (for different reason though ;-). -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html