From: David Miller <davem@davemloft.net>
To: pablo@netfilter.org
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/3] netlink: add netlink_dump_control structure for netlink_dump_start()
Date: Sun, 26 Feb 2012 14:26:58 -0500 (EST) [thread overview]
Message-ID: <20120226.142658.2102259598074884751.davem@davemloft.net> (raw)
In-Reply-To: <1330129817-28199-2-git-send-email-pablo@netfilter.org>
From: pablo@netfilter.org
Date: Sat, 25 Feb 2012 01:30:15 +0100
> From: Pablo Neira Ayuso <pablo@netfilter.org>
>
> Davem considers that the argument list of this interface is getting
> out of control. This patch tries to address this issue following
> his proposal:
>
> struct netlink_dump_control c = { .dump = dump, .done = done, ... };
>
> netlink_dump_start(..., &c);
>
> Suggested by David S. Miller.
>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Applied.
next prev parent reply other threads:[~2012-02-26 19:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 0:30 [PATCH 0/3] netlink: netlink_dump_start takes pointer to data pablo
2012-02-25 0:30 ` [PATCH 1/3] netlink: add netlink_dump_control structure for netlink_dump_start() pablo
2012-02-25 1:12 ` Jan Engelhardt
2012-02-25 13:22 ` Pablo Neira Ayuso
2012-02-26 19:26 ` David Miller [this message]
2012-02-25 0:30 ` [PATCH 2/3] netlink: allow to pass data pointer to netlink_dump_start() callback pablo
2012-02-26 19:27 ` David Miller
2012-02-25 0:30 ` [PATCH 3/3] netfilter: ctnetlink: support kernel-space dump filtering by ctmark pablo
2012-02-25 0:41 ` Pablo Neira Ayuso
2012-02-26 19:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120226.142658.2102259598074884751.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).