From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 2/6] netfilter: ctnetlink: remove incorrect spin_[un]lock_bh on NAT module autoload Date: Tue, 06 Mar 2012 15:15:20 -0500 (EST) Message-ID: <20120306.151520.1301826446269910707.davem@davemloft.net> References: <1331032975-5303-1-git-send-email-pablo@netfilter.org> <1331032975-5303-3-git-send-email-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org To: pablo@netfilter.org Return-path: Received: from shards.monkeyblade.net ([198.137.202.13]:39136 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030958Ab2CFUQZ (ORCPT ); Tue, 6 Mar 2012 15:16:25 -0500 In-Reply-To: <1331032975-5303-3-git-send-email-pablo@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: From: pablo@netfilter.org Date: Tue, 6 Mar 2012 12:22:51 +0100 > From: Pablo Neira Ayuso > > Since 7d367e0, ctnetlink_new_conntrack is called without holding > the nf_conntrack_lock spinlock. Thus, ctnetlink_parse_nat_setup > does not require to release that spinlock anymore in the NAT module > autoload case. > > Signed-off-by: Pablo Neira Ayuso Applied.