From: Pablo Neira Ayuso <pablo@netfilter.org>
To: David Miller <davem@davemloft.net>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 6/6] netfilter: nf_conntrack: fix early_drop with reliable event delivery
Date: Wed, 7 Mar 2012 14:19:20 +0100 [thread overview]
Message-ID: <20120307131920.GA6499@1984> (raw)
In-Reply-To: <20120306.151618.683601515842945468.davem@davemloft.net>
On Tue, Mar 06, 2012 at 03:16:18PM -0500, David Miller wrote:
> From: pablo@netfilter.org
> Date: Tue, 6 Mar 2012 12:22:55 +0100
>
> > From: Pablo Neira Ayuso <pablo@netfilter.org>
> >
> > If reliable event delivery is enabled and ctnetlink fails to deliver
> > the destroy event in early_drop, the conntrack subsystem cannot
> > drop any the candidate flow that was planned to be evicted.
> >
> > Reported-by: Kerin Millar <kerframil@gmail.com>
> > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
>
> Applied.
>
> > + /* Check if we indeed killed this entry. Reliable event
> > + delivery may have inserted it into the dying list. */
> > + if (test_bit(IPS_DYING_BIT, &ct->status)) {
>
> Please don't allow misformatted comments like this into your
> tree next time, this should be:
>
> /* Check if we indeed killed this entry. Reliable event
> * delivery may have inserted it into the dying list.
> */
Thanks for spotting this.
Will in the future (probably some patches that I took for net-next
may not follow this format either, but for upcoming patches I will).
prev parent reply other threads:[~2012-03-07 13:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 11:22 [PATCH 0/6] netfilter fixes for 3.3-rc6 pablo
2012-03-06 11:22 ` [PATCH 1/6] netfilter: ebtables: fix wrong name length while copying to user-space pablo
2012-03-06 20:15 ` David Miller
2012-03-06 11:22 ` [PATCH 2/6] netfilter: ctnetlink: remove incorrect spin_[un]lock_bh on NAT module autoload pablo
2012-03-06 20:15 ` David Miller
2012-03-06 11:22 ` [PATCH 3/6] netfilter: ctnetlink: use GFP_ATOMIC in all allocations pablo
2012-03-06 12:50 ` Eric Dumazet
2012-03-06 14:48 ` Pablo Neira Ayuso
2012-03-06 15:09 ` Eric Dumazet
2012-03-06 15:35 ` Pablo Neira Ayuso
2012-03-06 20:20 ` David Miller
2012-03-06 11:22 ` [PATCH 4/6] netfilter: bridge: fix wrong pointer dereference pablo
2012-03-06 20:15 ` David Miller
2012-03-06 11:22 ` [PATCH 5/6] bridge: netfilter: don't call iptables on vlan packets if sysctl is off pablo
2012-03-06 20:15 ` David Miller
2012-03-06 11:22 ` [PATCH 6/6] netfilter: nf_conntrack: fix early_drop with reliable event delivery pablo
2012-03-06 20:16 ` David Miller
2012-03-07 13:19 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307131920.GA6499@1984 \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).