netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iptables: missing free() in function cache_add_entry()
@ 2012-03-08 14:20 Christian Engelmayer
  2012-03-12 12:09 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Engelmayer @ 2012-03-08 14:20 UTC (permalink / raw)
  To: netfilter-devel; +Cc: christian.engelmayer, franz.flasch

From: Franz Flasch <franz.flasch@frequentis.com>

Fixed a memory leak in the error path of function cache_add_entry().

Signed-off-by: Franz Flasch <franz.flasch@frequentis.com>
Signed-off-by: Christian Engelmayer <christian.engelmayer@frequentis.com>
---

--- iptables-1.4.12.2/libiptc/libiptc.c	2012-01-02 18:19:09.000000000 +0100
+++ iptables-1.4.12.2-modified/libiptc/libiptc.c	2012-03-08 14:24:24.000000000 +0100
@@ -1012,6 +1012,7 @@ new_rule:
 			if (t->target.u.target_size
 			    != ALIGN(sizeof(STRUCT_STANDARD_TARGET))) {
 				errno = EINVAL;
+				free(r);
 				return -1;
 			}
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] iptables: missing free() in function cache_add_entry()
  2012-03-08 14:20 [PATCH] iptables: missing free() in function cache_add_entry() Christian Engelmayer
@ 2012-03-12 12:09 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2012-03-12 12:09 UTC (permalink / raw)
  To: Christian Engelmayer; +Cc: netfilter-devel, franz.flasch

On Thu, Mar 08, 2012 at 03:20:37PM +0100, Christian Engelmayer wrote:
> From: Franz Flasch <franz.flasch@frequentis.com>
> 
> Fixed a memory leak in the error path of function cache_add_entry().

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-12 12:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-08 14:20 [PATCH] iptables: missing free() in function cache_add_entry() Christian Engelmayer
2012-03-12 12:09 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).