From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Maciej Żenczykowski" <zenczykowski@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] mark newly opened fds as FD_CLOEXEC (close on exec) [part 2]
Date: Thu, 22 Mar 2012 12:21:20 +0100 [thread overview]
Message-ID: <20120322112120.GA16645@1984> (raw)
In-Reply-To: <CAHo-OozsBkyQ-hq0Hkuef3uohemnHCh1qBo02By-kE5Rpt92Lg@mail.gmail.com>
Hi Maciej,
On Wed, Mar 21, 2012 at 01:50:59PM -0700, Maciej Żenczykowski wrote:
> > True, but CLOEXEC on iptables... I mean... how is it mandatory ?
>
> I'm not sure what you mean by mandatory.
If this patch is needed, I think we have to stick to fcntl for
backward compatibility reasons as well.
> iptables does potentially fork/exec modprobe to load modules.
> That can cause a selinux 'domain'/'role'/whatever-it-is-called crossing.
> You can do automated inspection of what gets carried across such
> privilege changes and any unexpected open file descriptors flag
> problems, patches like this cut down on the noise.
Could you resend the patch including the description of the precise
problem that this fixes in selinux?
IMO, if the patch description would have include since the beginnging
why that CLOEXEC is needed, we would have save a couple of emails.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-03-22 11:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 10:52 [PATCH] mark newly opened fds as FD_CLOEXEC (close on exec) [part 2] Maciej Żenczykowski
2012-03-21 20:27 ` Eric Dumazet
2012-03-21 20:40 ` Maciej Żenczykowski
2012-03-21 20:44 ` Eric Dumazet
2012-03-21 20:50 ` Maciej Żenczykowski
2012-03-22 11:21 ` Pablo Neira Ayuso [this message]
2012-03-23 10:26 ` Pablo Neira Ayuso
2012-03-24 9:11 ` Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322112120.GA16645@1984 \
--to=pablo@netfilter.org \
--cc=eric.dumazet@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).