From: Florian Westphal <fw@strlen.de>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] libxt_hashlimit: add support for byte-based operation
Date: Tue, 8 May 2012 16:21:34 +0200 [thread overview]
Message-ID: <20120508142134.GH5015@breakpoint.cc> (raw)
In-Reply-To: <alpine.LNX.2.01.1205081523540.6920@frira.vanv.qr>
Jan Engelhardt <jengelh@inai.de> wrote:
> On Tuesday 2012-05-08 15:16, Florian Westphal wrote:
>
> > I've re-used the existing options. For example,
> > --hashlimit-mode srcip,dstip,srcport,dstport --hashlimit\-above 512kb/s would
> > match when the flow exceeded 512kbytes per second.
> >
> > Similarily, the --hashlimit-burst parameter now either a number (packetcount)
> > number, or a "byte" suffix, e.g. "--hashlimit-burst 1mb".
> >
> > If you believe that we should introduce new options instead, please
> > let me know and I'll re-spin the patch.
>
> libxt_rateest also deals with rate suffixes, so it would seem to be
> worthwhile to investigate a new option type.
Good point, it would indeed be nice to avoid code duplication.
I'll look into it, thanks for pointing this out.
next prev parent reply other threads:[~2012-05-08 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 13:16 [PATCH] libxt_hashlimit: add support for byte-based operation Florian Westphal
2012-05-08 13:31 ` Jan Engelhardt
2012-05-08 14:21 ` Florian Westphal [this message]
2012-05-14 8:33 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508142134.GH5015@breakpoint.cc \
--to=fw@strlen.de \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).