From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH next] netfilter: xt_hashlimit: use _ALL macro to reject unknown flag bits
Date: Mon, 14 May 2012 10:23:40 +0200 [thread overview]
Message-ID: <20120514082340.GA9577@1984> (raw)
In-Reply-To: <1336723914-3074-1-git-send-email-fw@strlen.de>
On Fri, May 11, 2012 at 10:11:54AM +0200, Florian Westphal wrote:
> David Miller says:
> The canonical way to validate if the set bits are in a valid
> range is to have a "_ALL" macro, and test:
> if (val & ~XT_HASHLIMIT_ALL)
> goto err;"
>
> make it so.
Applied, thanks Florian.
prev parent reply other threads:[~2012-05-14 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 8:11 [PATCH next] netfilter: xt_hashlimit: use _ALL macro to reject unknown flag bits Florian Westphal
2012-05-14 8:23 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514082340.GA9577@1984 \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).