From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] [RFC] netfilter: don't assume NFPROTO_* are like PF_* Date: Mon, 14 May 2012 21:06:35 +0200 Message-ID: <20120514190635.GE14897@1984> References: <1337003909-2582-1-git-send-email-alban.crequy@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alban Crequy , Patrick McHardy , Vincent Sanders , Javier Martinez Canillas , netfilter-devel@vger.kernel.org, netdev@vger.kernel.org To: Jan Engelhardt Return-path: Received: from mail.us.es ([193.147.175.20]:44116 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753955Ab2ENTGi (ORCPT ); Mon, 14 May 2012 15:06:38 -0400 Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Mon, May 14, 2012 at 05:09:54PM +0200, Jan Engelhardt wrote: > > On Monday 2012-05-14 15:58, Alban Crequy wrote: > >--- a/include/linux/netfilter.h > >+++ b/include/linux/netfilter.h > >@@ -62,11 +62,11 @@ enum nf_inet_hooks { > > > > enum { > > NFPROTO_UNSPEC = 0, > >- NFPROTO_IPV4 = 2, > >- NFPROTO_ARP = 3, > >- NFPROTO_BRIDGE = 7, > >- NFPROTO_IPV6 = 10, > >- NFPROTO_DECNET = 12, > >+ NFPROTO_IPV4, > >+ NFPROTO_ARP, > >+ NFPROTO_BRIDGE, > >+ NFPROTO_IPV6, > >+ NFPROTO_DECNET, > > NFPROTO_NUMPROTO, > > }; > > This must not be changed under any circumstances. It is exported to > and used by userspace. (Except perhaps for NFPROTO_DECNET, which > refers to a quite dead protocol that I think no user parts have ever > used NFPROTO_DECNET.) I would consider it acceptable to change the > value for NFPROTO_DECNET if Pablo joins. If there is some remote posibility to break userspace code, I won't take the patch, sorry.