From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] conntrackd: resolve a compiler error
Date: Thu, 31 May 2012 16:15:03 +0200 [thread overview]
Message-ID: <20120531141503.GA1340@1984> (raw)
In-Reply-To: <alpine.LNX.2.01.1205311547570.31132@frira.zrqbmnf.qr>
On Thu, May 31, 2012 at 03:50:11PM +0200, Jan Engelhardt wrote:
>
> On Thursday 2012-05-31 15:31, Florian Westphal wrote:
> >> >
> >> > CC parse.o
> >> > parse.c: In function 'msg2ct':
> >> > parse.c:258:34: error: 'NULL' undeclared (first use in this function)
> >> > parse.c:258:34: note: each undeclared identifier is reported only once for each function it appears in
> >> > parse.c: In function 'msg2exp':
> >> > parse.c:438:16: error: 'NULL' undeclared (first use in this function)
> >>
> >> Similar patch was already applied.
> >>
> >> http://git.netfilter.org/cgi-bin/gitweb.cgi?p=conntrack-tools.git;a=commit;h=d44489648c1a56d543a84bbebe455227bb25cf34
> >
> >NULL is defined in stddef.h, stdlib.h does not necessarily pull that
> >header in, too.
>
> I believe that the C standard defines that NULL has to become available
> through (at least) stdio.h. Though wikipedia may not always be authoritative,
> I will use it as an excuse now: http://en.wikipedia.org/wiki/Stdio.h
>
> So if #include <stddef.h> makes NULL available, good for glibc, but it
> may not satisfy certain implementations.
As soon the compilation works, I'll be happy to use the more precise
header. Send me one patch upon the current git HEAD, I'll take it.
prev parent reply other threads:[~2012-05-31 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 12:03 conntrack-tools: 1 pending fix Jan Engelhardt
2012-05-31 12:03 ` [PATCH] conntrackd: resolve a compiler error Jan Engelhardt
2012-05-31 13:19 ` Pablo Neira Ayuso
2012-05-31 13:31 ` Florian Westphal
2012-05-31 13:50 ` Jan Engelhardt
2012-05-31 14:15 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531141503.GA1340@1984 \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).